Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Publisher] Agency Settings: Settings page + Account Tab (2/5) #1256 #1306

Closed
wants to merge 2 commits into from
Closed

[Publisher] Agency Settings: Settings page + Account Tab (2/5) #1256 #1306

wants to merge 2 commits into from

Conversation

corypride
Copy link
Collaborator

Description of the change

Updated styling for the Agency Settings, Team Management and associated files in order to combine Agency Settings and Team Management into one Settings page with two tabs (“Account” & “Team Members” - w/ the first tab being the default selected tab).

RecidivizSettingsPgRefactor2.mp4

Type of change

All pull requests must have at least one of the following labels applied (otherwise the PR will fail):

Label Description
Type: Bug non-breaking change that fixes an issue
Type: Feature non-breaking change that adds functionality
Type: Breaking Change fix or feature that would cause existing functionality to not work as expected
Type: Non-breaking refactor change addresses some tech debt item or prepares for a later change, but does not change functionality
Type: Configuration Change adjusts configuration to achieve some end related to functionality, development, performance, or security
Type: Dependency Upgrade upgrades a project dependency - these changes are not included in release notes

Related issues

Closes #1256

Checklists

Development

This box MUST be checked by the submitter prior to merging:

  • [X ] Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

  • Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@corypride
[Publisher]Agency Settings: edit profileDropdownMetadata and create G…
e6cd6cb 
…lobalStyles.tsx (#1271)

* [Publisher]Agency Settings: edit profileDropdownMetadata to replace 'Your Account,' 'Agency Settings,' and 'Team Management' with the option 'Settings'. Added GlobalStyles.tsx

* [Publisher]GlobalStyles.tsx: add license header and 2 component skeletons

* [Publisher]GlobalStyles.tsx: removed extra whitespace characters

* [Publisher]GlobalStyles.tsx: ran yarn lint --fix

* [Publisher]Settings.tsx and SettingsMenu: refactor and removal

* Revert "[Publisher]Settings.tsx and SettingsMenu: refactor and removal"

This reverts commit 54373c1.
@corypride
[Publisher]Agency Settings: refactor of Settings.tsx and removal of S…
0d90bdb 
…ettingsMenu.tsx (#1272)

* [Publisher]Agency Settings: edit profileDropdownMetadata to replace 'Your Account,' 'Agency Settings,' and 'Team Management' with the option 'Settings'. Added GlobalStyles.tsx

* [Publisher]GlobalStyles.tsx: add license header and 2 component skeletons

* [Publisher]GlobalStyles.tsx: removed extra whitespace characters

* [Publisher]GlobalStyles.tsx: ran yarn lint --fix

* [Publisher]Settings.tsx and SettingsMenu: refactor and removal
@corypride corypride marked this pull request as draft April 15, 2024 17:38
@corypride corypride closed this Apr 16, 2024
@corypride
Copy link
Collaborator Author

#1308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxosman mxosman Awaiting requested review from mxosman

@lilidworkin lilidworkin Awaiting requested review from lilidworkin

Assignees
No one assigned
Labels
Type: Breaking Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Publisher][Design Update] Agency Settings: Settings page + Account Tab (2/5)
1 participant
@corypride