Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please enforce No Explicit Any #257

Open
martin-braun opened this issue Nov 26, 2022 · 3 comments
Open

Please enforce No Explicit Any #257

martin-braun opened this issue Nov 26, 2022 · 3 comments
Labels
Priority: Low Nice addition, maybe... someday...

Comments

@martin-braun
Copy link

martin-braun commented Nov 26, 2022

Suggestion

Nobody likes to see the usage of any, please consider enforcing the policy.

@martin-braun martin-braun added Status: Triage This issue needs to be triaged. Type: Idea Marks an idea, which might be accepted and implemented. labels Nov 26, 2022
@RebeccaStevens
Copy link
Owner

Could you explain what you mean.
This codebase isn't using any anywhere (except here, where their use shouldn't be noticeable to end users)

@RebeccaStevens RebeccaStevens added Status: Awaiting Response Issue or PR awaits response from the creator. and removed Type: Idea Marks an idea, which might be accepted and implemented. labels Nov 26, 2022
@martin-braun
Copy link
Author

@RebeccaStevens This is exactly what I meant. It's good that it's not exposed, but it's not very welcomed to see. Please see this comment to understand where I'm coming from.

Can't we get rid of those anys as well?

@RebeccaStevens
Copy link
Owner

I would remove them, if possible, but I believe I had issues getting things to work without them.

Those anys are just generics within an extends clause of a conditional type.
Those lines essentially say "is given value a key that exists in the interface DeepMergeMergeFunctionURItoKind? The generics of that interface are not important".

@RebeccaStevens RebeccaStevens added Priority: Low Nice addition, maybe... someday... and removed Status: Triage This issue needs to be triaged. Status: Awaiting Response Issue or PR awaits response from the creator. labels Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Nice addition, maybe... someday...
Projects
None yet
Development

No branches or pull requests

2 participants