Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No factories should subscribeOn() the Platform thread #80

Open
thomasnield opened this issue Nov 29, 2018 · 0 comments
Open

No factories should subscribeOn() the Platform thread #80

thomasnield opened this issue Nov 29, 2018 · 0 comments

Comments

@thomasnield
Copy link
Collaborator

I've noticed there are a few factories left that call subscribeOn(JavaFxScheduler.platform() unnecessarily. I actually noticed this causes some issues with ObservableSet change streams, and emissions are not firing on changes.

But removing the scheduler causes it to work fine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thomasnield