New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaFxObservable.valuesOf(fxObservable, nullSentinel) does not emmit first nullSentinel #75

Open

pkrysztofiak opened this issue Nov 10, 2018 · 1 comment

pkrysztofiak commented Nov 10, 2018 •

edited

In my opinion the first/initial emission of nullSentinel is missing:

ObjectProperty<String> stringProperty = new SimpleObjectProperty<>();
JavaFxObservable.valuesOf(stringProperty, "N/A").subscribe(System.out::println);  
stringProperty.set("one");  
stringProperty.set(null);  
stringProperty.set("two");

Output:
one
N/A
two

I would add "else" block just after "if" at ObservableValueSource:50

if (fxObservable.getValue() != null) {
    emitter.onNext(fxObservable.getValue());
} else {
    emitter.onNext(nullSentinel);
}

Collaborator

thomasnield commented Nov 12, 2018

Noted, okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment