Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES modules do not work #342

Closed
ukstv opened this issue Apr 21, 2022 · 2 comments · Fixed by #363
Closed

ES modules do not work #342

ukstv opened this issue Apr 21, 2022 · 2 comments · Fixed by #363

Comments

@ukstv
Copy link

ukstv commented Apr 21, 2022

Pals, the project is awesome. Yet, despite all the effort dedicated to packaging, one can not use it in Node16, from ES modules.

First, you do not use conditional exports to specify import paths like ix/asynciterable or ix/asynciterable/operators.

Second, the JS code which is supposed to conform to ES modules format uses extension-less imports.
For example, in ix-esnext-esm/asynciterable/index.js one could find a line like export * from './batch'; It should be export * from './batch.js'; for Node to parse it.

Let me know if I can help with moving this to pure ESM. Now it sucks, and it is a great disappointment for me. I am willing to volunteer here.

@trxcllnt
Copy link
Member

Yeah, the node ESM stuff has changed (again) since we last updated the packaging. I think we've finally got it all working in Arrow, I just haven't back-ported the changes to the IxJS build system yet.

I wrote the IxJS and Arrow build scripts around the same time and intended to support the same things, so they are very similar. Now just have to port the Arrow updates back here, but haven't had time.

@trxcllnt
Copy link
Member

Fixed in v6.0.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants