-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert free functions to static functions #2926
Comments
Static functions are more autocomplete-friendly, so I would vote for that. |
A benefit of free functions is that you don't need to think about whether something is a |
I agree with @JaviSoto. For people that know RAC well, free functions are not an issue, I would argue for novice to mid level discoverability can be an issue. |
The Swift API guidelines are pretty clear on this.
These functions are basically fancy constructors, so using the metatype as |
This was done in #3001! 🎉 |
Should non-instance methods be free functions or static functions?
Because currently we have:
But we also have:
We should standardize on one or the other for RAC 5.0.
I'd vote free functions, but I'm curious if someone thinks we should be using static functions. @ReactiveCocoa/reactivecocoa
The text was updated successfully, but these errors were encountered: