-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xcode 7.3 beta 5 miscompiles SignalProducerType.combineLatestWith
on ARM64
#2751
Comments
I can't even begin to express how excited I am to see a Swift contributor open an issue, not only explaining the bug but offering a workaround 😍 If it's not fixed by the GM we can temporarily make this change in #2684, since we'll likely need to change other things for Thanks a lot @jckarter 😄 |
Yes! Thank you!!! 😍 |
@jckarter Is there an issue on bugs.swift.org that we can follow as well? |
Not that I know of. The radar unfortunately contains a private project I can't post publicly. |
@calebd reports that this is still an issue on the final 7.3. I'm finishing the download now. I'll make a branch with |
Running tests with -O (and ensuring `ENABLE_TESTABILITY` is `YES`) crash.
Fixed by #2760. |
Let's keep this open so that we remember to get rid of the workaround once this is fixed in Swift :) |
@jckarter Any idea if this will be fixed in the 2.2.x milestone? |
We'll try, at least. We're looking into it. |
Looks like @eeckstein has a fix on the way: apple/swift#1916 |
It seems that this is fixed by apple/swift#1937 and Xcode 7.3.1 / Swift 2.2.1 contains the fix. https://github.com/apple/swift/releases/tag/swift-2.2.1-RELEASE |
This was originally introduced in #2751, but it's not necessary anymore. Tests pass with `-O`!.
The workarounds have been removed for Swift 3! |
I hate to incovenience you all, but we have a bug in the 7.3 betas that causes us to miscompile the currying of
Signal.combineLatestWith
here:I'm investigating a fix right now. In case we don't fix it in time for 7.3 final, I recommend hand-inlining the
liftRight
combinator here as a workaround,The bug on our side is rdar://problem/24960559, for reference.
The text was updated successfully, but these errors were encountered: