Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thermo via Clapeyron.jl (OpenSAFT) #157

Open
longemen3000 opened this issue Aug 10, 2021 · 2 comments
Open

Thermo via Clapeyron.jl (OpenSAFT) #157

longemen3000 opened this issue Aug 10, 2021 · 2 comments

Comments

@longemen3000
Copy link
Contributor

longemen3000 commented Aug 10, 2021

I created this issue, as mentioned in Juliacon, to track progress in integration of external thermo models to this package, via Clapeyron.jl. If I remember correctly, a volume solver is necessary. Also, for multicomponent mixtures, a dew and bubble pressure solver could be used to mark limits on zones where 2-phase mixtures could occur

@longemen3000
Copy link
Contributor Author

Maybe the best option to integration is by catching the thermo in the rms file format?

@mjohnson541
Copy link
Collaborator

Sorry, somehow I didn't see this earlier. Yeah, so RMS's parser is based on recursively constructing object dictionaries within the input .yml. For example in the .yml: Dict(["type"=>"Arrhenius", "A"=>1.3,"n"=>1.0,"Ea"=>40136.0]) gets converted to an Arrhenius struct. We can probably make modifications to the procedure, but it might be easier to just add the parameters we need and then write phase objects (or if possible a very generic phase object) that bulid all the Clapeyron objects and call them appropriately to get the thermochemistry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants