-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update storybook UI #33
Comments
Hey man, I sent you an email about this but I'll comment here too I sorta got storybook styled to match the UI but it was crazy hacky Storybook 5 improves theming but doesn't seem to offer much customisation either from the little I've looked into it |
Hi, @padraigfl ! Talking with @allyssonsantos, it comes to us that there is no way to get storybook styled without We waited for the version 4 for this "fix", I guess, and it did not come even in the 5, btw. About your project, what an awesome repo you have! There are a lot of components we don't have in React95. It seems easy for you to contribute if you want! We will dig carefully your repo and if it has something we could pull into, we will mention your project in |
We don't add a theme issue yet but, we discuss it a lot. I do not remember how many themes Windows95 had but Windows98 could be one in React95, why not? |
Hi @padraigfl! What a great project, you nailed it! In the future we can create some kind of themification to achieve all Windows95 themes, there's a lot of them: So, we are in the same page @ggdaltoso 😄 We can also include the Windows98 UI, but we'll need more modification than just change colors (Like the Windows95 themes), I do not think if this is a theme or something else, but is there that the @padraigfl project can help a lot! |
atm I'm just focusing on seeing if I can actually make something useful outta my thing but I'm probably making some new fonts soon (e.g. the notepad font is kinda important for my current project) and I'll add them here in PRs. Quite a lot of it is hacky hacky and I was learning things as I done them, it's basically chrome on desktop only atm. That being said, I'm sure there's some stuff there that's roughly correct, just sloppy, lemme know if something is really confusing and I'll (try) to explain the objective. Here's a gatsby implementation, you can kinda see how some of the styles aren't flexible enough https://confident-brown-2595eb.netlify.com/ |
Speaking of Gatsby, tbh I'd just do a component library in Gatsby if the aesthetics are important. Storybook is a kind of high functional thing that only really is of value if you go to town on the knobs and addons |
It's time to leave storybook. Let's build an windows explorer UI to show our components, what do you think @ggdaltoso? |
We should have done this form the beginning! |
No description provided.
The text was updated successfully, but these errors were encountered: