bug(Reddit): Failed to patch Reddit v2024.18.0+

[cyberboh]

Bug description

After reddit updated to v2024.18.0, its fail to be patched.
Was work on previous Reddit 2024.17.0
Using CLI 4.6.0 with default patches selected.

java -jar revanced-cli-4.6.0-all.jar patch -p -o Install\Reddit_2024.18.0-all_ReVanced.apk --options options.json -b revanced-patches-4.8.0-dev.9.jar --keystore-entry-alias=****** --keystore-password=****** --keystore-entry-password=****** --keystore=******.keystore -m revanced-integrations-1.9.0-dev.6.apk Apps\com.reddit.frontpage-2024.18.0-all.apk

Error logs

WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Reddit_2024.18.0-all_ReVanced-temporary-files\patcher\apk\res\values\styles.xml:2661: error: expected enum but got (raw string) 0.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Reddit_2024.18.0-all_ReVanced-temporary-files\patcher\apk\res\values\styles.xml:3268: error: expected enum but got (raw string) 1.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Reddit_2024.18.0-all_ReVanced-temporary-files\patcher\apk\res\values\styles.xml:3271: error: expected enum but got (raw string) 1.
WARNING: E:\ANDROID\APPS\ReVanced\Patched\Install\Reddit_2024.18.0-all_ReVanced-temporary-files\patcher\apk\res\values\styles.xml:3303: error: expected enum but got (raw string) 1.
WARNING: error: failed linking references.
brut.androlib.exceptions.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [C:\Users\User\AppData\Local\Temp\brut_util_Jar_160464020939428848823309772031326134023.tmp, link, -o, E:\ANDROID\APPS\ReVanced\Patched\Install\Reddit_2024.18.0-all_ReVanced-temporary-files\patcher\patched\resources\resources.apk, --package-id, 127, --min-sdk-version, 26, --target-sdk-version, 34, --version-code, 1577901, --version-name, 2024.18.0, --no-auto-version, --no-version-vectors, --no-version-transitions, --no-resource-deduping, --allow-reserved-package-id, --warn-manifest-validation, -e, C:\Users\User\AppData\Local\Temp\APKTOOL7857465341792012760.tmp, -0, arsc, -I, E:\ANDROID\APPS\ReVanced\Patched\Install\Reddit_2024.18.0-all_ReVanced-temporary-files\patcher\1.apk, --manifest, E:\ANDROID\APPS\ReVanced\Patched\Install\Reddit_2024.18.0-all_ReVanced-temporary-files\patcher\apk\AndroidManifest.xml, E:\ANDROID\APPS\ReVanced\Patched\Install\Reddit_2024.18.0-all_ReVanced-temporary-files\patcher\apk\build\resources.zip]
        at brut.androlib.AaptInvoker.invokeAapt2(AaptInvoker.java:249)
        at brut.androlib.AaptInvoker.invokeAapt(AaptInvoker.java:394)
        at app.revanced.patcher.data.ResourceContext.get(ResourceContext.kt:134)
        at app.revanced.patcher.Patcher.get(Patcher.kt:268)
        at app.revanced.cli.command.PatchCommand.run(PatchCommand.kt:312)
        at picocli.CommandLine.executeUserObject(CommandLine.java:2026)
        at picocli.CommandLine.access$1500(CommandLine.java:148)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
        at picocli.CommandLine.execute(CommandLine.java:2170)
        at app.revanced.cli.command.MainCommandKt.main(MainCommand.kt:12)
Caused by: brut.common.BrutException: could not exec (exit code = 1): [C:\Users\User\AppData\Local\Temp\brut_util_Jar_160464020939428848823309772031326134023.tmp, link, -o, E:\ANDROID\APPS\ReVanced\Patched\Install\Reddit_2024.18.0-all_ReVanced-temporary-files\patcher\patched\resources\resources.apk, --package-id, 127, --min-sdk-version, 26, --target-sdk-version, 34, --version-code, 1577901, --version-name, 2024.18.0, --no-auto-version, --no-version-vectors, --no-version-transitions, --no-resource-deduping, --allow-reserved-package-id, --warn-manifest-validation, -e, C:\Users\User\AppData\Local\Temp\APKTOOL7857465341792012760.tmp, -0, arsc, -I, E:\ANDROID\APPS\ReVanced\Patched\Install\Reddit_2024.18.0-all_ReVanced-temporary-files\patcher\1.apk, --manifest, E:\ANDROID\APPS\ReVanced\Patched\Install\Reddit_2024.18.0-all_ReVanced-temporary-files\patcher\apk\AndroidManifest.xml, E:\ANDROID\APPS\ReVanced\Patched\Install\Reddit_2024.18.0-all_ReVanced-temporary-files\patcher\apk\build\resources.zip]
        at brut.util.OS.exec(OS.java:104)
        at brut.androlib.AaptInvoker.invokeAapt2(AaptInvoker.java:245)
        ... 13 more

Solution

No response

Additional context

No response

Acknowledgements

• This issue is not a duplicate of an existing bug report.
• I have chosen an appropriate title.
• All requested information has been provided properly.

[oSumAtrIX]

Since AAPT is failing this is something that can't be fixed unless it's fixed in the resource decoder of Androlib of AAPT. The only thing this repository can do is to constrain to the last working version until the former is done

[cyberboh]

Since AAPT is failing this is something that can't be fixed unless it's fixed in the resource decoder of Androlib of AAPT. The only thing this repository can do is to constrain to the last working version until the former is done

Who can fix AAPT issues? Google themself?

Anyway, 2024.17.0 is last working version.

[inotia00]

The related issue is iBotPeaches/Apktool#3534, and I don't think it will be possible to fix it for some time.

Maybe implementing arsc-lib might be a solution.

Anyway, in order to avoid user confusion, it is better for Reddit to limit the supported versions.

[ascopes]

Can the patches be updated to recommend the last working version within the Revanced Manager app? Right now it says "any version" which isn't reflective of what is supported unfortunately.

Had to do some digging to find this thread... some other people who are not as fluent with GitHub might struggle! 🙂

[ascopes]

Am I looking at the wrong thing in that case? I reinstalled the manager 10 minutes before commenting here

[oSumAtrIX]

Feel free to open a PR. Only resource patches need to be constrained.

[ascopes]

Will see if I can get some time tomorrow to try and work out what I need to change and how!