Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update outdated and vulnerable jQuery version #488

Open
jklingen opened this issue Apr 28, 2022 · 3 comments
Open

Docs: Update outdated and vulnerable jQuery version #488

jklingen opened this issue Apr 28, 2022 · 3 comments

Comments

@jklingen
Copy link

A tool brought to my attention that your documentation includes an outdated version of jQuery, which has several known vulnerabilities.

I don't know whether any of those actually cause a threat, but you might want to update it anyway, just to be safe.

Recommended fix is upgrading to jQuery >= 3.5.0

See also: https://snyk.io/test/npm/jquery/3.3.1

@DivineDominion
Copy link
Contributor

@jklingen Thanks for reporting this!

Would you be up to the task of making a PR for the documentation? The template is in https://github.com/ReSwift/ReSwift/tree/master/Docs/jazzy-theme/assets/js

@jklingen
Copy link
Author

I can offer to create a PR replacing the JS file, but I can't promise it won't break anything 😏 I don't know Jazzy and what it uses jQuery for. And I haven't been using jQuery for ages, so I am not sure what kind of changes are included in the updated versions.

But if it helps nevertheless, I'm happy to create a PR.

@mjarvis
Copy link
Member

mjarvis commented Apr 28, 2022

Its likely this is using a default theme from Jazzy, and that we can likely update jazzy / the theme, and theoretically they have updated their dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants