Setting a Route without Triggering the Router #26
Labels
Comments
mjarvis
pushed a commit
that referenced
this issue
Dec 13, 2016
Necessary for mutating route specific data without causing navigation changes.
The desired usage here would be that `oldState.map { $0.instanceIdentifier } == newState.map { $0.instanceIdentifier}`, and has significant side effects (described below) if not the case.
Note this carries a risk of having unintended effects if the user uses this incorrectly as it could cause the UI & navigationState to go out-of-sync if one changes the actual segments in the route.
However, the above side effect also Fixes #26, in that one can use this to react to UIKit based changes to the route. (IE system UINavigationBar back button)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In some cases, when UIKit performs a transition that we cannot force through the router, we need to notify the router about the change (also discussed in #17).
In such cases we might want to update the route, without triggering the actual routing. If the transition already happened directly from within UIKit we don't want to trigger another action in the router.
We'll need to add this to the API of the router in form of a new action. Maybe we could call it
NotifyOfNewRoute(route).The text was updated successfully, but these errors were encountered: