Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob or raw URL for pdfs? #44

Open
oliviaguest opened this issue Aug 30, 2017 · 6 comments
Open

blob or raw URL for pdfs? #44

oliviaguest opened this issue Aug 30, 2017 · 6 comments

Comments

@oliviaguest
Copy link
Member

I was just adding an article to the website and noticed that in the list (here: https://rescience.github.io/read/) some of the links to PDFs go to the .../blob/... and some to the .../raw/... directory/URL.

Blob does this (the the PDF preview being rendered by GH): https://github.com/ReScience-Archives/Stollmeier-2017/blob/master/article/Stollmeier-2017.pdf

While raw does this (direct link to the file, so in my browser it opens a dialogue to save the PDF): https://github.com/ReScience-Archives/Stollmeier-2017/raw/master/article/Stollmeier-2017.pdf

Which is the "right" one? Or do we not mind?

@khinsen
Copy link
Contributor

khinsen commented Aug 30, 2017

There are good arguments for either one. My personal preference is linking to raw, which is how pretty much everyone outside the GitHub universe presents links to PDF.

@oliviaguest
Copy link
Member Author

It's a mix of both now — do we want to be consistent?

@khinsen
Copy link
Contributor

khinsen commented Aug 30, 2017

I'd say yes, but before we change anything we need to agree on this (vote?)

@oliviaguest
Copy link
Member Author

I vote raw.

@fa-ahmad
Copy link

fa-ahmad commented Mar 25, 2020

Blob also doesn't seem to work on mobile phones. At least a couple of Android mobile phones we tried on.

@rougier
Copy link
Member

rougier commented Mar 30, 2020

Did we do it in the end ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants