Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revdeps new errors in rbindlist due to class mis-match #5542

Closed
tdhock opened this issue Nov 27, 2022 · 2 comments · May be fixed by #5446
Closed

revdeps new errors in rbindlist due to class mis-match #5542

tdhock opened this issue Nov 27, 2022 · 2 comments · May be fixed by #5446
Labels
rbindlist revdep Reverse dependencies

Comments

@tdhock
Copy link
Member

tdhock commented Nov 27, 2022

revdep heuristicsmineR has the following new error when running examples if data.table from github master is installed,

* checking examples ... ERROR
Running examples in 'heuristicsmineR-Ex.R' failed
The error most likely occurred in:

> ### Name: as.petrinet
> ### Title: Converts the object to a Petrinet
> ### Aliases: as.petrinet
> 
> ### ** Examples
> 
> data(L_heur_1)
> cn <- causal_net(L_heur_1, threshold = .8)
Error in rbindlist(l, use.names, fill, idcol) : 
  Class attribute on column 7 of item 2 does not match with column 7 of item 1.
Calls: causal_net ... merge -> merge.data.table -> rbind -> rbind -> rbindlist
Execution halted

git bisect says this started happening after merging #5263
@ben-schwen can you please have a look? (you were author of that PR)

@tdhock
Copy link
Member Author

tdhock commented Nov 27, 2022

A similar error, started happening after merging the same PR, in revdep table.express:

* checking tests ...
  Running 'testthat.R'
 ERROR
Running the tests in 'tests/testthat.R' failed.
Last 13 lines of output:
  
  == Failed tests ================================================================
  -- Error (???): Full join works. -----------------------------------------------
  Error in `rbindlist(l, use.names, fill, idcol)`: Class attribute on column 4 of item 2 does not match with column 4 of item 1.
  Backtrace:
      x
   1. +-base::merge(...)
   2. \-data.table::merge.data.table(...)
   3.   \-base::rbind(dt, y[missingyidx], use.names = FALSE, fill = TRUE)
   4.     \-data.table (local) rbind(deparse.level, ...)
   5.       \-data.table::rbindlist(l, use.names, fill, idcol)
  
  [ FAIL 1 | WARN 0 | SKIP 1 | PASS 614 ]
  Error: Test failures
  Execution halted

@tdhock tdhock changed the title revdep heuristicsmineR example error in rbindlist revdeps new errors in rbindlist due to class mis-match Nov 27, 2022
@tdhock tdhock added the revdep Reverse dependencies label Nov 27, 2022
@tdhock
Copy link
Member Author

tdhock commented Apr 4, 2023

Update: heuristicsmineR published a new version on CRAN (0.3.0, 2023-04-04), but actually this issue is still happening.

@jangorecki jangorecki modified the milestone: 1.15.0 Dec 22, 2023
@tdhock tdhock closed this as completed Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rbindlist revdep Reverse dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants