Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing instance records in fvar::Table #129

Open
zimond opened this issue Sep 20, 2023 · 3 comments
Open

Missing instance records in fvar::Table #129

zimond opened this issue Sep 20, 2023 · 3 comments

Comments

@zimond
Copy link
Contributor

zimond commented Sep 20, 2023

related #120.

I think based on the spec, there are instance records in fvar. But currently ttf-parser only parses axis record?

@RazrFalcon
Copy link
Owner

Yes, it is not implemented.

@zimond
Copy link
Contributor Author

zimond commented Sep 21, 2023

@RazrFalcon do you mind if I submit a PR for this?

@RazrFalcon
Copy link
Owner

Sure. Note that the PostScript name field is optional, making parsing more convoluted, since you cannot use read_array16

You can check it using:

let has_post_script_name = instance_length == (axes_count * 4) + 6;

I guess the only way to implement it is by creating a custom wrapper for InstanceRecords data blob with a get method that will do the parsing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants