-
Notifications
You must be signed in to change notification settings - Fork 0
D241B specific setup and configuration #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ksl0
wants to merge
3
commits into
Master
Choose a base branch
from
local_configuration_241B
base: Master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason - the EyeTracking Matlab files are different enough on the D241B rig, where the code on the "Master" Github branch is incompatible with the data that is generated here. When pressing on the "Dessacade & Get Scale Factors" on the "Eye Analysis" piece, it brings up some errors. Hypothesis: * Channel file update? The importSpike in the getScaleFactors_App.m uses a different set of integers - likely this refers to the channels?
ksl0
commented
Dec 13, 2022
Comment on lines
+10
to
+12
| % If | ||
|
|
||
| % an error returns, click the link and install the OS Generic Video |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| % If | |
| % an error returns, click the link and install the OS Generic Video | |
| % If an error returns, click the link and install the OS Generic Video |
remove extra whitespace
| chanlist = readSpikeFile(fullfile(params.folder,[params.file '.smr']),[]); | ||
| chanindsAll = [chanlist.number]; | ||
| chanlabels = {'hhpos','htpos','hepos1','hepos2','hepos','vepos','hhvel','htvel','htvel','TTL3','TTL4'}; | ||
| chanlabels = {'hhpos','htpos','hepos1','hepos2','hepos','vepos','hhvel','htvel','TTL3','TTL4'}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be a configuration file that gets read in?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: unclear to me why D241B has different Matlab data analysis code