Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image is supported #19

Open
doskoi opened this issue Dec 13, 2018 · 5 comments
Open

Docker image is supported #19

doskoi opened this issue Dec 13, 2018 · 5 comments
Labels
enhancement New feature or request

Comments

@doskoi
Copy link

doskoi commented Dec 13, 2018

I have created a docker image that can easily to setup build environment, the repo is here: https://github.com/doskoi/RavenLRS

It has been tested on Docker CE on macOS Mojave and Windows 10 Pro, Linux Mint 19 (apt install docker.io)

You can have some tests, and put this in README to help users to use raven. or fork this into your project.

@doskoi
Copy link
Author

doskoi commented Jan 8, 2019

@fiam You can use docker image as same as inav to put a build.sh in project, the script is accpet build target as parameter to passthrough to the make CLI.

@fiam
Copy link
Collaborator

fiam commented Jan 8, 2019

@doskoi This is definitely very nice. Would you like to submit a PR or would you prefer that I link to your repo from the README?

@doskoi
Copy link
Author

doskoi commented Jan 9, 2019 via email

@doskoi
Copy link
Author

doskoi commented Jan 10, 2019

Well, because the Dockerfile is included clone raven operation, so if I want to use it inside the raven folder, I need to make some changes.

@nmaggioni nmaggioni added the enhancement New feature or request label Jan 10, 2019
@doskoi
Copy link
Author

doskoi commented Jan 13, 2019

I've made the update and tested, now it works via build.sh in raven folder or initialize project via docker commands in empty folder.

Pull request: #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants