Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust suggested pipeline as soon as tensorflow-text supports Windows #6482

Closed
chkoss opened this issue Aug 25, 2020 · 3 comments
Closed

adjust suggested pipeline as soon as tensorflow-text supports Windows #6482

chkoss opened this issue Aug 25, 2020 · 3 comments
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@chkoss
Copy link
Contributor

chkoss commented Aug 25, 2020 •
edited by m-vdb

Once tensorflow-text supports Windows, we should

  • add it as a dependency on Windows, too = remove this marker
  • change the autoconfiguration to suggest the same pipeline for Windows as for other operating systems = remove this if-case

Currently blocked by this issue: tensorflow/text#44
@chkoss chkoss added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Aug 25, 2020
@chkoss chkoss mentioned this issue Aug 25, 2020
Merged
4 tasks
@RasaHQ RasaHQ deleted a comment from sara-tagger Aug 25, 2020
@sara-tagger
Copy link
Collaborator

Thanks for submitting this feature request 🚀 @JustinaPetr will get back to you about it soon! ✨

@chkoss
Copy link
Contributor Author

chkoss commented Aug 26, 2020 •
edited

Can't prevent Sara from tagging people... 😭 @JustinaPetr please ignore, it's a Production Squad issue for the future.

@wochinge
Copy link
Contributor

Closing this as we now have one config for all OSes which doesn't user convert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wochinge @chkoss @sara-tagger