Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace audioop with Python equivalent #9529

Closed
wants to merge 1 commit into from
Closed

Replace audioop with Python equivalent #9529

wants to merge 1 commit into from

Conversation

davidhozic
Copy link

@davidhozic davidhozic commented Aug 20, 2023 •
edited

Summary

Replaces audioop with Python equivalent inside discord.PCMVolumeTransformer.read().
Resolves #9477 .

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Rapptz
Copy link
Owner

Rapptz commented Aug 20, 2023

Thanks for the PR but this isn't what we plan on doing.

@Rapptz Rapptz closed this Aug 20, 2023
@davidhozic davidhozic deleted the feat/audioop branch August 20, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of deprecated module audioop
2 participants
@davidhozic @Rapptz