Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backbone doesn't respond to changes in ES5 Maps/Sets, even new ones #33

Closed
martingraham opened this issue Jun 2, 2016 · 1 comment
Closed

Comments

@martingraham
Copy link

Backbone compares old and new .set values using the Underscore libraries isEqual method.

This at the moment doesn't work for Maps/Sets, it will return equals is true for any two Maps or any two Sets

It's getting worked on jashkenas/underscore#2451

but will need some sort of hacky fix in the meantime (Backbone has some sort of force change method).

That took most of the day :-)

@martingraham
Copy link
Author

Fixed by forcing Backbone change event, will do it normally once underscore updates to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants