Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS80P screen orientation upside down #1849

Open
GrigoriOH opened this issue Nov 28, 2023 · 12 comments · May be fixed by #1894
Open

TS80P screen orientation upside down #1849

GrigoriOH opened this issue Nov 28, 2023 · 12 comments · May be fixed by #1894
Assignees

Comments

@GrigoriOH
Copy link

Describe the bug

With TS80P the automatic screen orientation is upside down.

To Reproduce

  1. Install version 2.22 on TS80P (maybe just specific devices as sometimes different motion sensors were installed)
  2. Start device
  3. Activate automatic screen orientation
  4. Screen upside down (left handed orientation when in right hand and vice versa)

Expected behavior

Screen in readable orientation for auto rotation mode.

Details of your device:

  • Device: TS80P
  • Release: 2.22
  • Board version: 1.2
  • Accelerometer: LIS2DH12

Additional context

This issue has already been addressed in #1021 and was resolved in version 2.17

Today after work I was able to try out some previous versions and found the following:

Version Orientation
2.22 wrong way up
2.22RC3 wrong way up
2.22RC2 wrong way up
2.22RC1 wrong way up
2.21 orientation is fine
2.20 orientation is fine
2.19 orientation is fine
2.18 orientation is fine
2.17 orientation is fine (original Version of fix)

If someone else stumbles over this issue, it might be a temporary fix to use v2.21. Also, I hope to be of some help finding the bug.

If you need some more information, please just let me know. 😃

@damex
Copy link

damex commented Nov 30, 2023

hi, i can confirm that old ts80p has the same behavior on 2.22. screen is upside down.

@ia
Copy link
Collaborator

ia commented Nov 30, 2023

Hello.

What is the motion sensitivity setting when the issue appears?
Have you tried to increase sensitivity to check if it solves the issue?
Does rotate not work even when you rotate the iron firmly but steady shaking it?

The bottom line is that I had minor issue with autorotate on TS80P in the past myself (checked on 2.22 right before the release) so I just disabled it. However, with sensitivity = 9 it used to work for me more or less bearable anyway. So, please, try to:

  • tweak motion sensitivity setting;
  • rotate the iron more firmly (to trigger accelerometer for sure).

Sorry if you did it already and it didn't help but the report didn't mention anything about it. Just, please, report back if anything from the advises helped anyway.

@GrigoriOH
Copy link
Author

GrigoriOH commented Nov 30, 2023

Hello Ivan.

  • tweak motion sensitivity setting;

The initial setting is 7.
I just changed it to 9 but the error persists: Screen is upside down and when I rotate the device, the orientation flips, hence the displayed content is upside down again. Even with sensitivity set to 0, the screen rotates.

  • rotate the iron more firmly (to trigger accelerometer for sure).

Both firm and soft rotation trigger the display rotation. I might have described the problem insufficiently. Auto rotation works / detects movements, but it always orients the display in the wrong direction.

Sorry if you did it already and it didn't help but the report didn't mention anything about it. Just, please, report back if anything from the advises helped anyway.

Nothing to be sorry about, I am grateful for any help/tip/trick as well as when I can assist you in finding a bug 😄

@Ralim
Copy link
Owner

Ralim commented Dec 9, 2023

So this is a pain. From what I recall from this last time it was the cloned LIS2DH12's that sometimes get into weird states depending on the order you probe the I2C bus for devices. For 2.22 I changed to a bit-banged I2C to work around miniware shipping yet-another-cloned stm device with I2C quirks.

The 2.22 firmware works fine for me here; though I have an early unit with a legit accel.

Just to rule out it being I2C timing first, can you try this file:
TS80P_EN.zip

@GrigoriOH
Copy link
Author

Please excuse the late reply!
I just uploaded your firmware, but unfortunately the automated screen rotation is still the wrong way. I guess I²C timing might not be the issue.

@sokerer
Copy link

sokerer commented Feb 15, 2024

I am having the same issue with 2.22, weird behaviours from the accelerometer, occasional upside down flips and no movement detections.
2.22 detects the acc as LIS2 clone

With 2.21 everything works perfectly , no issues at all
2.21 detects the acc as SC7A20

Hope that this can give a clue

@XENNOK
Copy link

XENNOK commented Feb 29, 2024

Same issue here. +1
2.22 upside down
2.21 works fine

@Ralim
Copy link
Owner

Ralim commented Mar 18, 2024

This was broken by TS101 support (#1695).
I should have a fix for this shortly for you to test 🙇🏼

@Ralim Ralim linked a pull request Mar 18, 2024 that will close this issue
@Ralim
Copy link
Owner

Ralim commented Mar 18, 2024

If you could try flashing the build from here and confirm if this is fixed or not would be mint.

@sokerer
Copy link

sokerer commented Mar 18, 2024 via email

@GrigoriOH
Copy link
Author

GrigoriOH commented Mar 19, 2024

Can confirm, unfortunately still upside down on TS80P with this version.

@Ralim
Copy link
Owner

Ralim commented May 14, 2024

Ah dangit.
Can you confirm if with the newer firmware the device is identified as the LIS or the LIS Clone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants