Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit the path from path in spectrome folder to path relative to current working directory. #15

Open
axiezai opened this issue Nov 5, 2019 · 1 comment
Open

Edit the path from path in spectrome folder to path relative to current working directory. #15

axiezai opened this issue Nov 5, 2019 · 1 comment
Assignees
@pfdamasceno @axiezai
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@axiezai
Copy link
Collaborator

axiezai commented Nov 5, 2019

The pathing from path.get_file_path is relative to spectrome directory right now, this should be changed to current working directory.

If people use spectrome as a library, they should be able to grab file paths relative to their own folders.
@axiezai axiezai added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels Nov 5, 2019
@axiezai
Copy link
Collaborator Author

axiezai commented Nov 5, 2019

  1. _file_ sets the path its looking for to within spectrome, which shouldn't be the case if you work with spectrome outside of the spectrome folders

  2. we probably only need get_file_path for relative path to any folder 1 level up, and get_data_path for data folder specific things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pfdamasceno pfdamasceno

@axiezai axiezai

Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pfdamasceno @axiezai