New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve AggregateRoot docs #980

Open

mostlyobvious opened this issue Jan 9, 2021 · 5 comments

Labels

Member

mostlyobvious commented Jan 9, 2021 •

edited by tomaszwro

one of most popular docs pages
does not depict current recommendations for AggregateRoot best practices
needs some background on why
link to arkency/aggregates and other newer resources
dissect event sourcing steps

mostlyobvious added the documentation label

Contributor

tomaszwro commented Jan 13, 2021 •

edited

Some things to be improved:

on instead of apply_
helper with_aggregate_root instead of default_event_store; see https://github.com/RailsEventStore/cqrs-es-sample-with-res/blob/master/lib/command_handler.rb
with_strategy instead of apply_strategy see https://github.com/RailsEventStore/rails_event_store/blob/master/aggregate_root/lib/aggregate_root.rb#L74-L85
examples from cqrs-es-sample-with-res can be used in docs

Contributor

tomaszwro commented Jan 13, 2021 •

edited

things to mention explicitly:

no side effects in handlers
two types of methods

Contributor

tomaszwro commented Jan 13, 2021

doc page in question: https://railseventstore.org/docs/v2/app/

Member Author

mostlyobvious commented Jun 20, 2022

testing event sourced aggregates (as discussed in Plans to deprecate `apply_*` handlers in AggregateRoot? #1345)

Member Author

mostlyobvious commented Jun 20, 2022

examples from cqrs-es-sample-with-res can be used in docs

this is now https://github.com/RailsEventStore/ecommerce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment