Support ActiveJob adapters with pre-deserialized events and NULL serializer #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the configuration of the ActiveJob backend and the serializer used - i.e. the `NULL` serializer -, it is possible that the argument to `perform` is already a full `Event` record. In that scenario, it can be used as-is without prior processing.
| def self.with_defaults | ||
| with | ||
| end | ||
| class << self |
There was a problem hiding this comment.
I don't think this was necessary change. Changing to class << self over self. made it harder to notice what really changed. A separate commit with only this change would be helpful in the future.
|
|
||
| # @return [Event] an event as deserialized from the payload | ||
| def event_from_payload(payload, event_store, serializer) | ||
| return payload if payload.kind_of?(RailsEventStore::Event) |
There was a problem hiding this comment.
We don't require Event objects in RES to be of this kind. It's likely they are but we accept anything that has the same interface as RES::Event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the configuration of the ActiveJob backend and the serializer used - i.e. the
NULLserializer -, it is possible thatthe argument to
performis already a fullEventrecord. In that scenario, it can be used as-is without prior processing.Closes #1334, even if the approach is different from how I understood the problem at first glance. But when taking a closer look at
Record,DeserializedRecordand the transformation pipeline I understood better the way things are related and decided on a more straightforward solution and just detecting that specific situation.