Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restartfix #126

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Restartfix #126

wants to merge 13 commits into from

Conversation

jonathan-beard
Copy link
Member

@jonathan-beard jonathan-beard commented Jul 21, 2020

Description

Enable restarting of streams.

Fixes #98

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Runs locally on Windows
  • Runs locally on Linux
  • Runs locally on OS X

Details

Please list details of the configurations of above local tests, specifically
relevant run details.

Please list test cases created to ensure your feature or addition
works.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

…e's a condition where the schedule function could still be running in a separate thread on exit, so, we need to make sure the kernels are destroyed after the schedule thread is shutdown
…that or add barrier or soemthing similar to wait on a specific kernel...or even make a new exe forrestart
…roper barrier, wanna re-organize a few things before then though.
… destructed before we're ready, need to check destructor chain from top level graph
…async free issue, sched thread is still inside the graph when terminate is called, will fix tomorrow
Remove Linux only header added for debugging
…o add test cases as well with the actual restart cases. We also likely need to add some way to nicely add new input params to graph every time we restart it in a loop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restarting the same stream
1 participant