New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package breaks with non-vulnerable Socket.Io version 4.1.2 #175

Open

monizb opened this issue Jun 14, 2021 · 1 comment

monizb commented Jun 14, 2021

When socket-io is upgraded to the latest non-vulnerable version 4.1.2 the status monitor package breaks all the routes

Error:

 TypeError: this.server.adapter(...) is not a constructor
    at Namespace._initAdapter (/Users/monish/Dropbox/My Mac (Monish’s MacBook Pro)/Desktop/DockIntern/backend/node_modules/express-status-monitor/node_modules/socket.io/dist/namespace.js:40:24)

The text was updated successfully, but these errors were encountered:

lamweili commented Jun 9, 2022

I don't think there is a commit for socket.io@4.1.2.
I'm using express-status-monitor@1.3.4 which upgraded to socket.io@4.4.1 with no issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment