Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FREEBOX DOWNLOAD] Incorrect File Import Handling When Downloading Multiple Movies #9938

Open
2 tasks done
YDeltagon opened this issue Apr 17, 2024 · 28 comments
Open
2 tasks done
Labels
Area: Download Clients Issue is related to download clients Priority: Low Issue does not affect Radarr functionality in a serious way. Status: Confirmed Stops stale bot from asking if stale Status: Help Wanted Help Wanted, no immediate plans for effort on this Type: Bug Issue is a bug

Comments

@YDeltagon
Copy link

Is there an existing issue for this?

  • I have searched the existing open and closed issues

Current Behavior

When using Freebox as the download client configured with Radarr, if multiple movies are downloaded into the same directory "radarr-films", Radarr incorrectly imports the first completed download as all the movies.
For example, when downloading the Harry Potter series, if "The Sorcerer’s Stone" finishes first, all subsequent imports in Radarr are recognized as "The Sorcerer’s Stone", despite Radarr assigning them different titles

image

Expected Behavior

Radarr should import each movie as a separate entity, respecting the individual completion and correct naming, ideally downloading each movie into a sub-folder named with the movie's download ID to avoid conflicts

image

Steps To Reproduce

  1. Configure Freebox as the download client in Radarr
  2. Initiate the download of multiple movies into the same target folder "radarr-films"
  3. Observe that the first completed download is imported as all movies in the series

Environment

- OS: W11 64bits
- Radarr: 5.4.6.8723 — 2024-04-13
- Using Reverse Proxy: Flaresolverr
- Browser: Chrome / Plex / LG WebOS / Android

What branch are you running?

Develop

Trace Logs? Not Optional

Is too long :\

Trace Logs have been provided as applicable. Reports will be closed if the required logs are not provided.

  • I have read and followed the steps in the wiki link above and provided the required trace logs - the logs contain trace - that are relevant and show this issue.
@YDeltagon YDeltagon added Status: Needs Triage New Issue needing triage Type: Bug Issue is a bug labels Apr 17, 2024
@bakerboy448 bakerboy448 added the Status: Logs Needed Logs are needed to proceed with this issue label Apr 17, 2024
Copy link

👋 @YDeltagon, In order to help you further we'll need to see logs. You'll need to enable trace logging and replicate the problem that you encountered. Guidance on how to enable trace logging can be found in our troubleshooting guide.

@bakerboy448 bakerboy448 added the Status: Waiting for OP Action Required from OP label Apr 17, 2024
@YDeltagon
Copy link
Author

YDeltagon commented Apr 18, 2024

On : "TRACE 11"
at : 2024-04-18 01:13:03.6

"Attempting to hardlink movie file: F:\Telechargements\Radarr-Films\Harry.Potter.and.the.Order.of.the.Phoenix.2007.2160p.UHD.BLURAY.REMUX.HDR.HEVC.Multi.VFF.DTS-X.7.1-romandelc.mkv to F:\Videos\Radarr-Films(1998) Taxi - {imdb-tt0152930}\Taxi () _ Remux-2160p - [HEVC DTS-X (7.1 [EN+FR]) (Sub [EN+FR]) - HDR10 10bits].mkv"

https://gist.github.com/YDeltagon/c93123d547c92b3efa3d422b8959a3e0#file-radarr_trace_freebox-import-txt-L418

image

@YDeltagon
Copy link
Author

After analyzing the logs and considering the configuration details, I suspect that the issue with movie file imports might be related to the copyusinghardlinks setting. Since my source (Freebox) and destination are not on the same operating system, this could potentially cause issues with hardlinking.

I'm planning to test the import process with the copyusinghardlinks option disabled to see if this resolves the issue. I'll provide an update based on the results of this test.

@YDeltagon
Copy link
Author

Same error

image
Good
image
Harry Potter : Kung Fu Edition ?

@bakerboy448
Copy link
Contributor

bakerboy448 commented Apr 18, 2024

Please provide the logs in the manner prescribed in the wiki you indicated you agreed to. No one will look through the tens of thousands of lines across 4 files for a niche client with a likely niche bug.

edit: logs in trace 11 that seems to have the issue also don't include the download client response and radarr parsing/details of the client items.

4 log files and uploaded directly to github is not what the wiki states.

copyusinghardlinks

not the issue. if hardlinks are not supported it falls back to copy+delete.

@bakerboy448 bakerboy448 added Priority: Low Issue does not affect Radarr functionality in a serious way. Area: Download Clients Issue is related to download clients labels Apr 18, 2024
@YDeltagon
Copy link
Author

YDeltagon commented Apr 18, 2024

@bakerboy448
Copy link
Contributor

still does not include the download client response and radarr parsing/details of the client items. only shows proccessing of files on disk

@YDeltagon
Copy link
Author

Gist update with 1 minute before

@mynameisbogdan
Copy link
Collaborator

Firstly, you have a bunch of corrupted mkv files.

Secondly, why is Taxi.1.1998.MULTi.BluRay.1080p.REMUX.AVC.HD-MA.5.1.x264-chrisj72.mkv renamed mid processing to Taxi.1. 1998 .FRENCH.BluRay.1080p.REMUX.AVC.TrueHD.5.1.x264-chrisj72?

@YDeltagon
Copy link
Author

I've tried repeatedly with various movies, but I keep encountering the same issue. My setup is similar to Sonarr, where I don't face many problems because it downloads into separate folders.

To resolve this, both Sonarr and Radarr should consider implementing a feature to download each movie into a dedicated folder named after a unique identifier (e.g., the download ID) Freebox/telechargement/radarr-films/DownloadID assigned by Sonarr and Radarr. This would address the issue as indicated in my first screenshot, where there is an option to set a variable for the folder name. Implementing this could significantly streamline the file management and import process.

Additionally, I'm puzzled as to why Radarr is detecting name changes, with spaces appearing and the ".mkv" disappearing, without any action on my part. It happens automatically. Also, I can confirm that the MKVs are not corrupted because they play perfectly fine, and manual imports work without any issues.

@mynameisbogdan
Copy link
Collaborator

I would like to see the trace logs after you add 2 movies to freebox, because I want to see /downloads/add in the logs.

Also are you using multiple download clients or just one instance of freebox?

@YDeltagon
Copy link
Author

One instance

@mynameisbogdan
Copy link
Collaborator

mynameisbogdan commented Apr 19, 2024

Do you plan to provide the trace logs I requested?

@YDeltagon
Copy link
Author

It's in progress. I've initiated ultra-light versions of two films and started the trace log. I'll send it over as soon as it's available.

@YDeltagon
Copy link
Author

19000 lines...
'm not sure how to make it easier for you with so many lines of log; I did my best, started the downloads, and just waited for the import.

Hang in there with all those lines!

https://gist.github.com/YDeltagon/bd76cb8723c86121d936307a21453706

image
image

@mynameisbogdan
Copy link
Collaborator

Thanks, those logs are somewhat helpful.

I'll provide you later with a build that contains a possible fix for you to test out.

@YDeltagon
Copy link
Author

Thank you very much, your responsiveness is impressive!
I'm available whenever it's convenient for you ;)

@mynameisbogdan
Copy link
Collaborator

https://radarr.servarr.com/v1/update/freebox-infohash/updatefile?os=windows&runtime=netcore&arch=x64&installer=true

Install this, give it a test and then provide new trace logs for 2 grabs like the previous ones.

@YDeltagon
Copy link
Author

Trace on new build : https://gist.github.com/YDeltagon/43cbc5f67df35c3c61525aa3fc624a7a
Not work

image

@mynameisbogdan
Copy link
Collaborator

Thanks for the logs. I'll push some log statements to a new build to see what's really going on.

@mynameisbogdan
Copy link
Collaborator

@YDeltagon Do you use any remote mappings? Can you show them in a screenshot?

@mynameisbogdan mynameisbogdan added Status: Confirmed Stops stale bot from asking if stale and removed Status: Needs Triage New Issue needing triage labels Apr 20, 2024
@mynameisbogdan mynameisbogdan removed Priority: Low Issue does not affect Radarr functionality in a serious way. Status: Logs Needed Logs are needed to proceed with this issue labels Apr 20, 2024
@mynameisbogdan
Copy link
Collaborator

'Freebox:Harry.Potter.Et.Les.Reliques.De.la.Mort.1ere.Partie.2010.FRENCH.BRRip.XviD.AC3-NoTag': ClientState=Completed (readonly) RadarrStage=Downloading Movie='Harry Potter Et Les Reliques De la Mort 1ere Partie - 2010 Bluray-480p v1' OutputPath=F:\Telechargements\Radarr-Films\.

The issue seems to be the OutputPath not containing the filename as well, just the download directory. While it works fine for Sonarr due to having subfolders for season packs, might not work for single episode files as well.

Considering the nature of this service, I'm unable to implement a fix by fetching the list of the torrent files to get the proper filename.

@YDeltagon
Copy link
Author

image
image
image
image

Hello, and voila

@mynameisbogdan mynameisbogdan added the Status: Help Wanted Help Wanted, no immediate plans for effort on this label Apr 20, 2024
@YDeltagon
Copy link
Author

YDeltagon commented Apr 20, 2024

'Freebox:Harry.Potter.Et.Les.Reliques.De.la.Mort.1ere.Partie.2010.FRENCH.BRRip.XviD.AC3-NoTag': ClientState=Completed (readonly) RadarrStage=Downloading Movie='Harry Potter Et Les Reliques De la Mort 1ere Partie - 2010 Bluray-480p v1' OutputPath=F:\Telechargements\Radarr-Films\.

The issue seems to be the OutputPath not containing the filename as well, just the download directory. While it works fine for Sonarr due to having subfolders for season packs, might not work for single episode files as well.

Considering the nature of this service, I'm unable to implement a fix by fetching the list of the torrent files to get the proper filename.

That's exactly what I thought. Sonarr doesn't encounter issues because it downloads into separate folders. For Radarr, it would be beneficial to have a variable in the "category" setting in my Freebox download client to manage each movie download into its own folder. This would help ensure that each movie is handled correctly and avoid the issues we're seeing with file importation.

image

@mynameisbogdan
Copy link
Collaborator

Like I said, Sonarr should have the same issue with single episodes.

Your suggestion is not a proper fix, someone with access needs to do the similar thing Qbittorrent does and to loop through the torrent files.

@YDeltagon
Copy link
Author

Like I said, Sonarr should have the same issue with single episodes.

Yes, sorry my english is not perfect, i use some "google trad"
Sonarr download saison on folder, yes - single ep, on the root download folder = bug

Thanks for your help 💯

@mynameisbogdan
Copy link
Collaborator

No problem. For now I can only recommend switching to something like qBittorrent until a French contributor takes a a jab at this.

@YDeltagon
Copy link
Author

I use " Blackhole"
I can't use qBittorrent because I can't put a VPN on my PC, otherwise, it messes up the game servers I host...
it's a bit of a mess on this PC :D

@bakerboy448 bakerboy448 added Priority: Low Issue does not affect Radarr functionality in a serious way. and removed Status: Waiting for OP Action Required from OP labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Download Clients Issue is related to download clients Priority: Low Issue does not affect Radarr functionality in a serious way. Status: Confirmed Stops stale bot from asking if stale Status: Help Wanted Help Wanted, no immediate plans for effort on this Type: Bug Issue is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants