Issue1451 add pvt model #1458
Open
Issue1451 add pvt model #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
FWuellhorst
requested changes
Sep 19, 2023
There was a problem hiding this comment.
Thanks for this addition to the AixLib.
The equation look correct, but there are some style-guide issues which need to be addressed. If you have questions, just comment below. Most of them were already wrong in the SolarThermal model, but we agreed on fixing those issues if we adapt existing models.
AixLib/DataBase/PhotovoltaicThermal/ElectricalGlazedPVTWithLowEmissionCoating.mo
Outdated
Show resolved
Hide resolved
AixLib/DataBase/PhotovoltaicThermal/ElectricalGlazedPVTWithLowEmissionCoating.mo
Outdated
Show resolved
Hide resolved
AixLib/DataBase/PhotovoltaicThermal/ElectricalGlazedPVTWithLowEmissionCoating.mo
Outdated
Show resolved
Hide resolved
AixLib/DataBase/PhotovoltaicThermal/ElectricalGlazedPVTWithoutLowEmissionCoating.mo
Outdated
Show resolved
Hide resolved
AixLib/DataBase/PhotovoltaicThermal/PhotovoltaicThermalBaseDataDefinitionElectrical.mo
Outdated
Show resolved
Hide resolved
…-model Corrected HTML Code in branch correct_HTML_issue1451-add-pvt-model
…/AixLib into issue1451-add-pvt-model
…-model Corrected HTML Code in branch correct_HTML_issue1451-add-pvt-model
…hange example for colder day
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a simple photovoltaic thermal collector based on the already existing solar thermal model