Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARAX is failing TRAPI 1.5 validation in CI #2275

Closed
maximusunc opened this issue May 1, 2024 · 7 comments
Closed

ARAX is failing TRAPI 1.5 validation in CI #2275

maximusunc opened this issue May 1, 2024 · 7 comments

Comments

@maximusunc
Copy link

Given this query:
https://ars.ci.transltr.io/ars/api/messages/0cc6b8e1-1814-48b7-b461-98a06574681e

Auxiliary Graphs are required to have an empty list of attributes and not null.
https://github.com/NCATSTranslator/ReasonerAPI/blob/master/TranslatorReasonerAPI.yaml#L800

@saramsey
Copy link
Member

saramsey commented May 1, 2024

Putting this on the agenda for today's all-hands meeting.

@edeutsch
Copy link
Collaborator

edeutsch commented May 2, 2024

@saramsey What was the outcome from the AHM? I don't see outcomes in the agenda.

We have another opportunity to push to TEST in the next couple days.

Would it be possible to have someone on this issue as a high prio so that we can get this fixed in TEST in the next push?

@dkoslicki
Copy link
Member

@kvnthomas98 would you be able to address this like you did with #2272? Apparently this is very high priority

@kvnthomas98
Copy link
Collaborator

Yes Sure! working on it now

@saramsey
Copy link
Member

saramsey commented May 2, 2024

Thank you @kvnthomas98

@kvnthomas98
Copy link
Collaborator

Hi @maximusunc ,
This is fixed in CI now

"aux_graph_N1_99": {
        "attributes": [],
        "edges": [
          "N1_99"
        ]
      }

@maximusunc
Copy link
Author

Confirmed in CI that ARAX is passing TRAPI validation. Thanks everyone!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants