You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed today that in the kg2c_lite.json file, the domain_range_exclusion property on edges appears to be a python boolean in a string - e.g., "False" rather than false:
Would it make sense to store that value as an actual boolean, rather than a string?
(I'm not actually sure what this property is for - think I missed that over the summer - so I could be wrong, but just thought it's a bit odd while I was working with the kg2c_lite.json file today..)
The text was updated successfully, but these errors were encountered:
amykglen
changed the title
Domain range exclusion property contains booleans in strings?
KG2c domain range exclusion property contains booleans in strings?
Oct 25, 2023
amykglen
changed the title
KG2c domain range exclusion property contains booleans in strings?
KG2c domain_range_exclusion property contains booleans in strings?
Oct 25, 2023
Its supposed to be a string as far as KG2c edge property is concerned. I consulted Erica about it when she implemented domain_range_exclusion for KG2pre. The current logic uses string comparison to filter the results from Plover at query time.
There is no issue in changing the domain_range_exclusion key to a json boolean in kg2c_lite.json but this has to be done before triggering the KG2.8.6c build and there are some Expand changes necessary that filter domain_range_exclusion nodes. IMO this can be slated for Winter before the next KG2c version build.
I noticed today that in the
kg2c_lite.json
file, thedomain_range_exclusion
property on edges appears to be a python boolean in a string - e.g.,"False"
rather thanfalse
:Would it make sense to store that value as an actual boolean, rather than a string?
(I'm not actually sure what this property is for - think I missed that over the summer - so I could be wrong, but just thought it's a bit odd while I was working with the
kg2c_lite.json
file today..)The text was updated successfully, but these errors were encountered: