New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If source directory has been bind-mounted, build breaks #770
Comments
Fixed this with a pleasingly minimal change here at : pevsonic@2fe8d47 |
Thanks! So I understand a bit better, could you please give an example output lines of 'mount' which demonstrate the situation where the problem would occur? |
Sure! So test scenario... on this machine, physical drive (bigssd) is mounted at
For example, fstab contains :
I create a new test project under
At the time of writing,
I then modify
And create a trivial config as per
This then crashes out with a failure containing the debug I added showing what's going on :
|
Fixed by d790fed thanks! |
On my Debian 12 workstation, the main large drive
/bigssd
has various subdirectories (e.g.projects
,home
,opt
...) that get bind mounted from the disks mount to their actual mount points on the filesystem. This has an interesting side-effect that when pi-gen mounts subdirs under $ROOTFS_DIR, mount reports them twice, for example :This would be OK, except that when you umount one, both become unmounted. In
scripts/common:unmount()
this will cause an error.I think that potentially calling
umount -f
might bypass this, but I think it would be better to construct the lists of directories to unmount more carefully instead.The text was updated successfully, but these errors were encountered: