Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of Free Events Error Handling #172

Open
nmcglo opened this issue Jan 3, 2020 · 3 comments
Open

Out of Free Events Error Handling #172

nmcglo opened this issue Jan 3, 2020 · 3 comments
Assignees

Comments

@nmcglo
Copy link
Member

nmcglo commented Jan 3, 2020

In its current state, when the simulation runs out of free event buffers, ROSS throws an error suggesting increasing --extramem= and exiting the simulation, requiring that the user try increasing this parameter and restarting.

Would it be possible to instead force a premature GVT update at this point to do some stale event recollection to see if this resolves the issue and then resume the simulation?

There should still probably be some stdout warning about what happened so that the user can know why their simulation is taking a lot of time if this forced GVT update happens really frequently. Maybe make this an opt-in feature via a command line argument so that a user who knows the risk of turning their optimistic simulation into something potentially worse than conservative if --extramem isn't set appropriately. But it might be better than killing a potentially 10 hour long running simulation.

There will need to be a check to see if the time since the last GVT is 0 to prevent the endless loop of "Out of events, perform GVT to recollect, still out of events, perform GVT to recollect..."

@carothersc-zz
Copy link
Member

carothersc-zz commented Jan 3, 2020 via email

@gonsie
Copy link
Member

gonsie commented Jan 21, 2020

We (here at LLNL) are looking at lazy rollback. But we would be very interested in a cancelback impelmentation if you wanted to tackle that @nmcglohon 😄

@nmcglo
Copy link
Member Author

nmcglo commented Jan 21, 2020

I could probably knock it out not too long after my next paper deadline. Assigning to myself.

@nmcglo nmcglo self-assigned this Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants