Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to deal with API changes? #5505

Closed
kaspar030 opened this issue Jun 3, 2016 · 6 comments
Closed

how to deal with API changes? #5505

kaspar030 opened this issue Jun 3, 2016 · 6 comments
Labels
Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR State: stale State: The issue / PR has no activity for >185 days

Comments

@kaspar030
Copy link
Contributor

currently, some (not all) of our API changes are announced on the mailing list, and some (not all) are mentioned in the release notes.

Is there a way to optimize this?

Ideas:

  • all of the API changes need to be announced on the mailing list, with a clear subject ("API CHANGE in foo_bar()" and a message body explaining how to fix legacy code,
  • we create a file API_CHANGES in the repo, and all API changing commits contain above information?

Or keep it as is - try to reasonably inform the crowd somehow?

@kaspar030 kaspar030 added the Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR label Jun 3, 2016
@miri64
Copy link
Member

miri64 commented Jun 3, 2016

I'm not sure we need the file, but the announcements to the mailing list are certainly a good idea.

@miri64
Copy link
Member

miri64 commented Jun 3, 2016

(on the other hand I hope we are getting to a point soonish, where API changes are something that happens rather rarely ;-))

@OlegHahm
Copy link
Member

OlegHahm commented Jun 3, 2016

Optimist. ;-)

@LudwigKnuepfer
Copy link
Member

I would suggest versionizing APIs so that users of an API will be notified at compile time when they need to update their code due to an API change.

i.e. something along the lines of (bear with me - untested):
my_api.h

#define MY_API_VERSION 4711
#if MY_API_VERSION_USED != MY_API_VERSION
#error my_api version does not match used version
#endif
...

usercode.c

#define MY_API_VERSION_USED 23
#include "my_api.h"
...

@stale
Copy link

stale bot commented Aug 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Aug 10, 2019
@kaspar030
Copy link
Contributor Author

  • mailing lists are notified on API changes now
  • no activity on the discussion for technical measures

closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR State: stale State: The issue / PR has no activity for >185 days
Projects
None yet
Development

No branches or pull requests

4 participants