Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/hashes: SHA-384, SHA-512/224 and SHA-512/256 support #20127

Closed
4 tasks done
mguetschow opened this issue Nov 30, 2023 · 6 comments · Fixed by #20598
Closed
4 tasks done

sys/hashes: SHA-384, SHA-512/224 and SHA-512/256 support #20127

mguetschow opened this issue Nov 30, 2023 · 6 comments · Fixed by #20598
Assignees

Comments

@mguetschow
Copy link
Contributor

mguetschow commented Nov 30, 2023

As a follow-up for #19969, implement the three FIPS specified truncated versions of SHA-512 in sys/hashes. For unified access, add frontend support for the PSA Crypto API, too.

  • SHA-384
  • SHA-512/224
  • SHA-512/256
  • PSA Crypto API support
@mguetschow mguetschow self-assigned this Dec 21, 2023
@Teufelchen1
Copy link
Contributor

Could you give a short status update? The soft feature freeze is on the 25th ;)

@mguetschow
Copy link
Contributor Author

Sure, I have an almost finished implementation at https://github.com/mguetschow/RIOT/tree/hashes-sha512-truncated including the necessary PSA Crypto glue code. Still outstanding:

  • SHA-384 seems to fail on the nrf52840dk cryptocell for some reason, although it should be supported according to the cryptocell API. This needs to be further investigated.
  • The PSA compilation tests in tests/sys/psa_crypto_* should be adapted to the change in examples/psa_crypto (they use a symlinked main.c)

If you wanted, I could split this in two PRs, one that adds truncated SHA512 support to sys/hashes and a second one that adds support for it to PSA crypto. The first one would be ready to be merged, while the second one would require some more work.

@Teufelchen1
Copy link
Contributor

If you wanted, ..

I think that's up to you!

I could split this in two PRs

The linked branch has 4 commits with around ~1800 edits. Could be enough to justify the overhead of splitting it in two PRs.

one that adds truncated SHA512 support to sys/hashes and a second one that adds support for it to PSA crypto

Both are probably minor enough to still get them in during soft-freeze :>

@mguetschow
Copy link
Contributor Author

see #20484 for the implementation in sys/hashes

@Teufelchen1
Copy link
Contributor

Everything is checked off! 🎉

Can this issue be closed?

@mguetschow
Copy link
Contributor Author

I would keep it open until #20598 is merged, which is currently hold back by #20545. The former should close the issue automatically as soon as it is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants