drivers/abp2: add abp2 driver #20398

dpproto · 2024-02-16T20:10:49Z

Contribution description

Add a driver for ABP2 Honeywell pressure and temperature series.
Implement a SAUL interface.
Support the SPI version, but not the I2C version (I don't have that one). However, prepare the code for easy I2C support.
Document the code.

Testing procedure

Use the test application in RIOT/tests/drivers/abp2.

Output of the test application:

=========================
        Measuring
=========================
Pressure range = 0 .. 160000
Data:            0.0003 Bar
Data:            17.151 °C 
Data:            0.0003 Bar
Data:            17.777 °C 
Data:            0.0003 Bar
Data:            17.207 °C
------------------------------
Switch to blocking mode
------------------------------
Data:            0.0003 Bar
Data:            17.111 °C
Data:            0.0003 Bar
Data:            17.180 °C
Data:            0.0003 Bar
Data:            17.139 °C
------------------------------
Switch to SAUL mode
------------------------------

Dev: Pressure sensor (abp2)     Type: SENSE_PRESS
Data:            0.0003 Bar

Dev: Temperature sensor (abp2)  Type: SENSE_TEMP
Data:            17.180 °C

Dev: Pressure sensor (abp2)     Type: SENSE_PRESS
Data:            0.0003 Bar

Dev: Temperature sensor (abp2)  Type: SENSE_TEMP
Data:            17.220 °C

Dev: Pressure sensor (abp2)     Type: SENSE_PRESS
Data:            0.0003 Bar

Dev: Temperature sensor (abp2)  Type: SENSE_TEMP
Data:            17.166 °C
------------------------------
Switch to non-blocking mode
------------------------------
Data:            0.0003 Bar
Data:            17.247 °C
Data:            0.0003 Bar
Data:            17.201 °C
Data:            0.0003 Bar
Data:            17.175 °C
------------------------------
Switch to blocking mode
------------------------------

Issues/PRs references

Fixes #20233

benpicco

Thank you for the contribution, that's a nice first driver!
Some comments:

drivers/abp2/abp2.c

drivers/include/abp2.h

tests/drivers/abp2/main.c

tests/drivers/abp2/setenv.venv

drivers/abp2/abp2.c

drivers/include/abp2.h

drivers/abp2/abp2_saul.c

tests/drivers/abp2/main.c

kfessel · 2024-03-13T15:12:00Z

your commits messages will need rewording

https://github.com/RIOT-OS/RIOT/blob/master/CONTRIBUTING.md#commit-conventions

dpproto · 2024-03-14T19:35:10Z

your commits messages will need rewording

https://github.com/RIOT-OS/RIOT/blob/master/CONTRIBUTING.md#commit-conventions

Could you be more accurate ?

kfessel · 2024-03-18T10:55:52Z

your commits messages will need rewording
https://github.com/RIOT-OS/RIOT/blob/master/CONTRIBUTING.md#commit-conventions

Could you be more accurate ?

Each commit should target changes of specific parts/modules of RIOT. The commits use the following pattern:

area of code: description of changes

You can use multi-line commit messages if you want to detail more the changes. For example:

periph/timer: Document that set_absolute is expected to wrap

Most timers are implemented this way already, and keeping (documenting)
it that way allows the generic timer_set implementation to stay as
simple as it is.

so you commit messages should be for example

driver/abp2: driver for SPI sensors prepare for I2C

tests/driver/abp2: test implementation

or something similar

the scheme is <arena of work>: <description>

tests/drivers/abp2/main.c

drivers/include/abp2.h

kfessel

aside from the leftover in the test app this seems good to go

please provide current test results from the current version starting at shell prompt
(I don't have the hardware to test)

tests/drivers/abp2/main.c

dpproto · 2024-03-22T17:03:14Z

aside from the leftover in the test app this seems good to go

That's good news!

please provide current test results from the current version starting at shell prompt (I don't have the hardware to test)

What do you mean? What about the program output in the 1st message of this thread?

kfessel · 2024-03-22T17:22:50Z

aside from the leftover in the test app this seems good to go

That's good news!

please provide current test results from the current version starting at shell prompt (I don't have the hardware to test)

What do you mean? What about the program output in the 1st message of this thread?

i see you updated it ( 1h ago there where non english words in it )

riot-ci · 2024-03-22T17:48:19Z

Murdock results

✔️ PASSED

b7198cc tests/drivers/abp2: test implementation

Success	Failures	Total	Runtime
10025	0	10026	10m:15s

Artifacts

drivers/saul/init_devs/auto_init_abp2.c

drivers/include/abp2.h

kfessel

some static tests ci style things

tests/drivers/abp2/main.c

drivers/abp2/abp2.c

Honeywell ABP2 pressure sensors series. Implement all sensors features, only supporting the SPI version of the sensor. Prepare future support for the I2C interface by emphasizing where to implement the code that will support the I2C bus version.

Use pseudomodules to add a dependency on the relevant feature: periph_spi if the abp2_spi pseudomodule is selected, or periph_i2c if the abp2_i2c pseudomodule is selected.

kfessel · 2024-03-25T14:56:03Z

diff --git a/tests/drivers/saul_drivers/Makefile b/tests/drivers/saul_drivers/Makefile
index c729dc575e..da6d708ee5 100644
--- a/tests/drivers/saul_drivers/Makefile
+++ b/tests/drivers/saul_drivers/Makefile
@@ -53,6 +53,9 @@ ifneq (,$(filter vl6180x,$(DRIVERS)))
   USEMODULE += vl6180x_als
   USEMODULE += vl6180x_rng
 endif
+ifneq (,$(filter abp2,$(DRIVERS)))
+  USEMODULE += abp2_spi
+endif
 
 USEMODULE += saul_default

dpproto · 2024-03-25T15:04:16Z

diff --git a/tests/drivers/saul_drivers/Makefile b/tests/drivers/saul_drivers/Makefile
index c729dc575e..da6d708ee5 100644
--- a/tests/drivers/saul_drivers/Makefile
+++ b/tests/drivers/saul_drivers/Makefile
@@ -53,6 +53,9 @@ ifneq (,$(filter vl6180x,$(DRIVERS)))
   USEMODULE += vl6180x_als
   USEMODULE += vl6180x_rng
 endif
+ifneq (,$(filter abp2,$(DRIVERS)))
+  USEMODULE += abp2_spi
+endif
 
 USEMODULE += saul_default

Should I apply these changes and force push?

Also, I noticed that entries in this file are sorted. So these lines should be added further up in the file.

kfessel · 2024-03-25T15:25:28Z

Should I apply these changes and force push?

yes (problem noticed by murdock)

Also, I noticed that entries in this file are sorted. So these lines should be added further up in the file.

please add the lines where they belong - good you noticed

kfessel · 2024-03-25T15:51:30Z

btw are you also working towards i2c support?

dpproto · 2024-03-25T15:56:20Z

btw are you also working towards i2c support?

I have no plan to do so because I don't have a I2C version at hand.

dpproto requested review from leandrolanzieri, jia200x, MrKevinWeiss, aabadie and MichelRottleuthner as code owners February 16, 2024 20:10

github-actions bot added Area: doc Area: Documentation Area: tests Area: tests and testing framework Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration labels Feb 16, 2024

dpproto force-pushed the 20233-add-abp2-driver branch from 1a59f06 to fcb2d07 Compare February 19, 2024 10:52

benpicco reviewed Feb 19, 2024

View reviewed changes

dpproto force-pushed the 20233-add-abp2-driver branch 4 times, most recently from e2c4682 to cba1b60 Compare February 20, 2024 14:47

kfessel reviewed Mar 8, 2024

View reviewed changes

drivers/abp2/abp2.c Outdated Show resolved Hide resolved

kfessel reviewed Mar 8, 2024

View reviewed changes

drivers/include/abp2.h Show resolved Hide resolved

kfessel reviewed Mar 8, 2024

View reviewed changes

drivers/include/abp2.h Outdated Show resolved Hide resolved

kfessel reviewed Mar 8, 2024

View reviewed changes

drivers/abp2/abp2_saul.c Outdated Show resolved Hide resolved

kfessel reviewed Mar 8, 2024

View reviewed changes

drivers/abp2/abp2_saul.c Outdated Show resolved Hide resolved

dpproto force-pushed the 20233-add-abp2-driver branch 3 times, most recently from 549c360 to 5230483 Compare March 11, 2024 08:12

kfessel reviewed Mar 13, 2024

View reviewed changes

tests/drivers/abp2/main.c Outdated Show resolved Hide resolved

tests/drivers/abp2/main.c Outdated Show resolved Hide resolved

kfessel changed the title ~~20233 add abp2 driver~~ drivers/abp2: add abp2 driver Mar 13, 2024

dpproto force-pushed the 20233-add-abp2-driver branch from 5230483 to 0e61666 Compare March 14, 2024 19:37

drivers/abp2: define default sensor parameters

790565a

dpproto force-pushed the 20233-add-abp2-driver branch from a1639ea to 0b5b176 Compare March 19, 2024 12:28

kfessel reviewed Mar 19, 2024

View reviewed changes

tests/drivers/abp2/main.c Outdated Show resolved Hide resolved

kfessel reviewed Mar 19, 2024

View reviewed changes

drivers/include/abp2.h Outdated Show resolved Hide resolved

kfessel reviewed Mar 19, 2024

View reviewed changes

drivers/include/abp2.h Outdated Show resolved Hide resolved

kfessel reviewed Mar 19, 2024

View reviewed changes

drivers/include/abp2.h Outdated Show resolved Hide resolved

dpproto force-pushed the 20233-add-abp2-driver branch from 0b5b176 to df8c901 Compare March 21, 2024 07:47

github-actions bot added the Area: SAUL Area: Sensor/Actuator Uber Layer label Mar 21, 2024

kfessel reviewed Mar 22, 2024

View reviewed changes

tests/drivers/abp2/main.c Outdated Show resolved Hide resolved

tests/drivers/abp2/main.c Outdated Show resolved Hide resolved

dpproto force-pushed the 20233-add-abp2-driver branch from df8c901 to 3126c7d Compare March 22, 2024 17:04

benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 22, 2024

kfessel reviewed Mar 22, 2024

View reviewed changes

drivers/saul/init_devs/auto_init_abp2.c Show resolved Hide resolved

kfessel reviewed Mar 22, 2024

View reviewed changes

drivers/include/abp2.h Outdated Show resolved Hide resolved

kfessel reviewed Mar 22, 2024

View reviewed changes

drivers/include/abp2.h Outdated Show resolved Hide resolved

kfessel reviewed Mar 22, 2024

View reviewed changes

dpproto force-pushed the 20233-add-abp2-driver branch from 3126c7d to e4d52c4 Compare March 25, 2024 08:57

kfessel reviewed Mar 25, 2024

View reviewed changes

drivers/abp2/abp2.c Outdated Show resolved Hide resolved

kfessel reviewed Mar 25, 2024

View reviewed changes

drivers/abp2/abp2.c Outdated Show resolved Hide resolved

dpproto added 2 commits March 25, 2024 13:55

drivers/abp2: implement the makefiles

c1ad1b5

Use pseudomodules to add a dependency on the relevant feature: periph_spi if the abp2_spi pseudomodule is selected, or periph_i2c if the abp2_i2c pseudomodule is selected.

dpproto force-pushed the 20233-add-abp2-driver branch from e4d52c4 to e01e24f Compare March 25, 2024 12:57

tests/drivers/abp2: test implementation

b7198cc

dpproto force-pushed the 20233-add-abp2-driver branch from e01e24f to b7198cc Compare March 25, 2024 15:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drivers/abp2: add abp2 driver #20398

drivers/abp2: add abp2 driver #20398

dpproto commented Feb 16, 2024 •

edited

benpicco left a comment

kfessel commented Mar 13, 2024 •

edited

dpproto commented Mar 14, 2024

kfessel commented Mar 18, 2024

kfessel left a comment •

edited

dpproto commented Mar 22, 2024

kfessel commented Mar 22, 2024

riot-ci commented Mar 22, 2024 •

edited

kfessel left a comment •

edited

kfessel commented Mar 25, 2024

dpproto commented Mar 25, 2024 •

edited

kfessel commented Mar 25, 2024

kfessel commented Mar 25, 2024

dpproto commented Mar 25, 2024

drivers/abp2: add abp2 driver #20398

Are you sure you want to change the base?

drivers/abp2: add abp2 driver #20398

Conversation

dpproto commented Feb 16, 2024 • edited

Contribution description

Testing procedure

Issues/PRs references

benpicco left a comment

Choose a reason for hiding this comment

kfessel commented Mar 13, 2024 • edited

dpproto commented Mar 14, 2024

kfessel commented Mar 18, 2024

kfessel left a comment • edited

Choose a reason for hiding this comment

dpproto commented Mar 22, 2024

kfessel commented Mar 22, 2024

riot-ci commented Mar 22, 2024 • edited

Murdock results

Artifacts

kfessel left a comment • edited

Choose a reason for hiding this comment

kfessel commented Mar 25, 2024

dpproto commented Mar 25, 2024 • edited

kfessel commented Mar 25, 2024

kfessel commented Mar 25, 2024

dpproto commented Mar 25, 2024

dpproto commented Feb 16, 2024 •

edited

kfessel commented Mar 13, 2024 •

edited

kfessel left a comment •

edited

riot-ci commented Mar 22, 2024 •

edited

kfessel left a comment •

edited

dpproto commented Mar 25, 2024 •

edited