Since NVDA 2023.3 voice addons are no longer loaded

[pvagner]

Hello,
Recently NV Access have released NVDA 2003.3 Beta 1. Most likelly as a part of their addon store polishing they are now enforcing three part version numbering for the addons as well. When parsing addon manifest.ini RHVoice addons are no longer loading after the update.
Here is an excerpt from the NVDA log:

ERROR - addonHandler._getAvailableAddonsFromPath (19:17:59.682) - MainThread (5112):
Error loading Addon from path: C:\tmp\nvda\userConfig\addons\RHVoice-voice-Slovak-Ondro
Traceback (most recent call last):
  File "addonHandler\__init__.pyc", line 299, in _getAvailableAddonsFromPath
  File "addonHandler\addonVersionCheck.pyc", line 70, in isAddonCompatible
  File "addonHandler\addonVersionCheck.pyc", line 56, in isAddonTested
  File "addonHandler\addonVersionCheck.pyc", line 27, in _isAddonForceDisabled
  File "_addonStore\models\version.pyc", line 28, in _parseVersionFromVersionStr
ValueError: Version string not valid: 4.3.1003.10

Looking at the NVDA code I can see version is forced to be three numbers delimited by dot, and there's also a versionName key in the manifest, however I am unable to find out where this is documented.
Quick and hacky solution is changing the version number to be formatted as major.minor.patch.

[zstanecic]

Hi, I cannot reproduce this on latest alphas, so maybe the people from NV Access will change something in the meantime. From: pvagner ***@***.***> Sent: Wednesday, September 13, 2023 9:19 PM To: RHVoice/RHVoice ***@***.***> Cc: Subscribed ***@***.***> Subject: [RHVoice/RHVoice] Since NVDA 2023.3 voice addons are no longer loaded (Issue #789) Hello, Recently NV Access have released NVDA 2003.3 Beta 1 <https://www.nvaccess.org/post/nvda-2023-3beta1/> . Most likelly as a part of their addon store polishing they are now enforcing three part version numbering for the addons as well. When parsing addon manifest.ini RHVoice addons are no longer loading after the update. Here is an excerpt from the NVDA log: ERROR - addonHandler._getAvailableAddonsFromPath (19:17:59.682) - MainThread (5112): Error loading Addon from path: C:\tmp\nvda\userConfig\addons\RHVoice-voice-Slovak-Ondro Traceback (most recent call last): File "addonHandler\__init__.pyc", line 299, in _getAvailableAddonsFromPath File "addonHandler\addonVersionCheck.pyc", line 70, in isAddonCompatible File "addonHandler\addonVersionCheck.pyc", line 56, in isAddonTested File "addonHandler\addonVersionCheck.pyc", line 27, in _isAddonForceDisabled File "_addonStore\models\version.pyc", line 28, in _parseVersionFromVersionStr ValueError: Version string not valid: 4.3.1003.10 Looking at the NVDA code I can see version is forced to be three numbers delimited by dot, and there's also a versionName key in the manifest, however I am unable to find out where this is documented. Quick and hacky solution is changing the version number to be formatted as major.minor.patch. — Reply to this email directly, view it on GitHub <#789> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACVCDE44Z64SLZM6MT5MVFTX2IBLNANCNFSM6AAAAAA4W57ZSY> . You are receiving this because you are subscribed to this thread. <https://github.com/notifications/beacon/ACVCDE5JGWP53SE5MDEE2ZTX2IBLNA5CNFSM6AAAAAA4W57ZS2WGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHHB5I7BQ.gif> Message ID: ***@***.*** ***@***.***> >

[pvagner]

NVDA issue does also exist. Most likelly for the 2023.3 version this is not going to be enforced after all.

[Olga-Yakovleva]

Some questions for people who are up-to-date on NVDA developments.

What is the deadline for addons to comply? Is this version format final or still in development?

It's a difficult requirement for RHVoice. To make things more convenient for users, each voice addon includes both the voice and the language pack, each of which is versioned independently, and the addon may also need an update for other reasons, which requires a separate version part. Right now the addon version consists of:

1. Two-part voice version. Changing that to a big single number will confuse users.

2. The part encoding the language version, which already joins the original two-part language version into a single number.

3. The number reserved to be incremented if the update of the addon is not related to a newer version of the language or voice, but to something else.

I don't want to merge the first and second numbers into one and thus create user confusion. So the only way RHVoice has to adapt is to split all its voice addons into pure voice and language addons. We used to do that, and it was a source of confusion too, so we started including language data with voices. Does the Store support dependencies like traditional package managers?

[zstanecic]

Hi, There is no deadline for this. This was unintentional bug, and it was fixed. Store doesn’t support dependencies like traditional package managers, because addons are not treated as such. There is no way to split again language and voice packages, as it will be the not only confusion for users, but it will be the confusion for language maintainers and creators. We are not forced to do anything, nor it was an Nv access recommendation to still change version numbers. If we ever want to add RHVoice to the add-on store, we just need to add add-on for the driver. It will be very inconvenient to have tons of RHVoice addons in store, because store doesn’t have categories. Let me discuss some thinks with NV access folks. From: Olga Yakovleva ***@***.***> Sent: Friday, September 15, 2023 10:49 AM To: RHVoice/RHVoice ***@***.***> Cc: Zvonimir Stanečić ***@***.***>; Comment ***@***.***> Subject: Re: [RHVoice/RHVoice] Since NVDA 2023.3 voice addons are no longer loaded (Issue #789) Some questions for people who are up-to-date on NVDA developments. What is the deadline for addons to comply? Is this version format final or still in development? It's a difficult requirement for RHVoice. To make things more convenient for users, each voice addon includes both the voice and the language pack, each of which is versioned independently, and the addon may also need an update for other reasons, which requires a separate version part. Right now the addon version consists of: 1. Two-part voice version. Changing that to a big single number will confuse users. 2. The part encoding the language version, which already joins the original two-part language version into a single number. 3. The number reserved to be incremented if the update of the addon is not related to a newer version of the language or voice, but to something else. I don't want to merge the first and second numbers into one and thus create user confusion. So the only way RHVoice has to adapt is to split all its voice addons into pure voice and language addons. We used to do that, and it was a source of confusion too, so we started including language data with voices. Does the Store support dependencies like traditional package managers? — Reply to this email directly, view it on GitHub <#789 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACVCDE6LH72CQACXDMX63R3X2QJAZANCNFSM6AAAAAA4W57ZSY> . You are receiving this because you commented. <https://github.com/notifications/beacon/ACVCDE6XRWQRY7XJ7PPE6XDX2QJAZA5CNFSM6AAAAAA4W57ZS2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTGSMDXA.gif> Message ID: ***@***.*** ***@***.***> >

[Olga-Yakovleva]

Ok, thank you, @zstanecic.

[pvagner]

Have you considered rewriting the NVDA addon so it will manage the voices internally similar how android app does it?
As @zstanecic said this time this was an unintentional error on NVDA's side. For the NVDA 2023.3 nothing is about to change.
To the future they are looking at making the version numbering more semantic so they can calculate upgrades more predictably in their addon store. Perhaps there are other reasons too.
Anyways they are not yet decided so given the fact the error is now resolved we can either close this or see this as a reminder that we will need to check later if at all and how to proceed later on.

[zstanecic]

Anyway, i am going to write to Sean and Quentin. I think that we need strong collaboration with them to coordinate things and follow up more when it comes to changes of things. Especially, we will need strong arguments behind changes, and we need to track these proactively. From: pvagner ***@***.***> Sent: Friday, September 15, 2023 11:44 AM To: RHVoice/RHVoice ***@***.***> Cc: Zvonimir Stanečić ***@***.***>; Mention ***@***.***> Subject: Re: [RHVoice/RHVoice] Since NVDA 2023.3 voice addons are no longer loaded (Issue #789) Have you considered rewriting the NVDA addon so it will manage the voices internally similar how android app does it? As @zstanecic <https://github.com/zstanecic> said this time this was an unintentional error on NVDA's side. For the NVDA 2023.3 nothing is about to change. To the future they are looking at making the version numbering more semantic so they can calculate upgrades more predictably in their addon store. Perhaps there are other reasons too. Anyways they are not yet decided so given the fact the error is now resolved we can either close this or see this as a reminder that we will need to check later if at all and how to proceed later on. — Reply to this email directly, view it on GitHub <#789 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACVCDE3E2SY66ATD4TDOFW3X2QPPXANCNFSM6AAAAAA4W57ZSY> . You are receiving this because you were mentioned. <https://github.com/notifications/beacon/ACVCDE6ESPGUSXUMEFUVGPDX2QPPXA5CNFSM6AAAAAA4W57ZS2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTGSQWTW.gif> Message ID: ***@***.*** ***@***.***> >

[zstanecic]

This can be closed.