Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompassContainerFromGatingSet parsing of node name #64

Open
Darylmorris68 opened this issue Dec 12, 2018 · 1 comment
Open

CompassContainerFromGatingSet parsing of node name #64

Darylmorris68 opened this issue Dec 12, 2018 · 1 comment

Comments

@Darylmorris68
Copy link

Darylmorris68 commented Dec 12, 2018

I'm having issues parsing a node name that includes parentheses.

>     Naive_pop[[iFile]] <- COMPASSContainerFromGatingSet(G[grep("HPV",pd$Sample)],node="Naive (CCR7+CD45RA+)",swap=FALSE,
+                                                              individual_id = "PTID.VISITNO",
+                                                              markers=c("CD25","CD69","CD137","CD154","OX40","PD-L1","PD-1"), 
+                                                              mp = list("Naive (CCR7+CD45RA+)/CD25+"   = "CD25",
+                                                                        "Naive (CCR7+CD45RA+)/CD69+"   = "CD69", 
+                                                                        "Naive (CCR7+CD45RA+)/CD137+"  = "CD137", 
+                                                                        "Naive (CCR7+CD45RA+)/CD154+"  = "CD154",
+                                                                        "Naive (CCR7+CD45RA+)/OX40+"   = "OX40",
+                                                                        "Naive (CCR7+CD45RA+)/PD-L1+"   = "PD-L1", 
+                                                                        "Naive (CCR7+CD45RA+)/PD-1+"   = "PD-1"))
Extracting cell counts
Error in COMPASSContainerFromGatingSet(G[grep("HPV", pd$Sample)], node = "Naive (CCR7+CD45RA+)",  : 
  The node expression /Naive (CCR7\+CD45RA\+)$ doesn't identify any nodes.
> traceback()
2: stop(gettextf("The node expression %s doesn't identify any nodes.", 
       node))
1: COMPASSContainerFromGatingSet(G[grep("HPV", pd$Sample)], node = "Naive (CCR7+CD45RA+)", 
       swap = FALSE, individual_id = "PTID.VISITNO", markers = c("CD25", 
           "CD69", "CD137", "CD154", "OX40", "PD-L1", "PD-1"), mp = list(`Naive (CCR7+CD45RA+)/CD25+` = "CD25", 
           `Naive (CCR7+CD45RA+)/CD69+` = "CD69", `Naive (CCR7+CD45RA+)/CD137+` = "CD137", 
           `Naive (CCR7+CD45RA+)/CD154+` = "CD154", `Naive (CCR7+CD45RA+)/OX40+` = "OX40", 
           `Naive (CCR7+CD45RA+)/PD-L1+` = "PD-L1", `Naive (CCR7+CD45RA+)/PD-1+` = "PD-1"))
> 
> 

When I escape, the parentheses in the node name, the problem moves.

>     Naive_pop[[iFile]] <- COMPASSContainerFromGatingSet(G[grep("HPV",pd$Sample)],node="Naive \\(CCR7+CD45RA+\\)",swap=FALSE,
+                                                              individual_id = "PTID.VISITNO",
+                                                              markers=c("CD25","CD69","CD137","CD154","OX40","PD-L1","PD-1"), 
+                                                              mp = list("Naive (CCR7+CD45RA+)/CD25+"   = "CD25",
+                                                                        "Naive (CCR7+CD45RA+)/CD69+"   = "CD69", 
+                                                                        "Naive (CCR7+CD45RA+)/CD137+"  = "CD137", 
+                                                                        "Naive (CCR7+CD45RA+)/CD154+"  = "CD154",
+                                                                        "Naive (CCR7+CD45RA+)/OX40+"   = "OX40",
+                                                                        "Naive (CCR7+CD45RA+)/PD-L1+"   = "PD-L1", 
+                                                                        "Naive (CCR7+CD45RA+)/PD-1+"   = "PD-1"))
Extracting cell counts
Fetching Naive (CCR7+CD45RA+)
Error in .cpp_getPopStats(x@pointer, sampleNames(x), y) : 
  Naive \(CCR7+CD45RA+\) not found!
@mikejiang
Copy link
Member

Looks like a bug in COMPASSContainerFromGatingSet, where the regular expression string from node argument (Naive \\(CCR7+CD45RA+\\)) was mistakenly passed down to the GatingSet API for node lookup.
Should be an easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants