Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump panel to 1.4.0 #379

Closed
pmeier opened this issue Mar 28, 2024 · 2 comments · Fixed by #312
Closed

Bump panel to 1.4.0 #379

pmeier opened this issue Mar 28, 2024 · 2 comments · Fixed by #312
Labels
type: maintenance 🛠️ Day-to-day maintenance tasks
Milestone

Comments

@pmeier
Copy link
Member

pmeier commented Mar 28, 2024

Was released today: https://blog.holoviz.org/posts/panel_release_1.4/ There are a few chat improvements that we should take a look at: https://blog.holoviz.org/posts/panel_release_1.4/#chat-improvements.

@pmeier pmeier added the type: maintenance 🛠️ Day-to-day maintenance tasks label Mar 28, 2024
@pmeier pmeier mentioned this issue Mar 28, 2024
@pmeier
Copy link
Member Author

pmeier commented Apr 2, 2024

Let's do a two-step approach here:

  1. Upgrade our requirement to panel==1.4.0 just making sure that everything that worked before still works.
  2. Check out the improvements that came with the new release and see if we can benefit from that.

This split is useful, since #312 can already be merged after 1. and I don't want to delay it any further.

@pmeier
Copy link
Member Author

pmeier commented Apr 2, 2024

Testing locally, I noticed two differences:

Loading indicator

loading_indicator_1_3_8.mp4
loading_indicator_1_4_0.mp4

Accordion rendering

accordion 1.4.0

accordion 1.3.8

Since both things are purely styling, I'm also ok to just merge the bump to 1.4.0 and fix the styling in #312. @pierrotsmnrd Thoughts?

@pmeier pmeier added this to the 0.3.0 milestone Apr 24, 2024
@pierrotsmnrd pierrotsmnrd linked a pull request May 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance 🛠️ Day-to-day maintenance tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant