Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DESIGN] Fix the color contrast of the syntax highlighter #824

Open
bskinn opened this issue Nov 30, 2023 · 0 comments
Open

[DESIGN] Fix the color contrast of the syntax highlighter #824

bskinn opened this issue Nov 30, 2023 · 0 comments
Labels
area: design 馃帹 area: react labs 馃敪 Items related to the Labs website owner: Quansight For Quansight work, regardless of timing/priority type: design flaw 馃Н Similar to a "bug" but for a design miss

Comments

@bskinn
Copy link
Contributor

bskinn commented Nov 30, 2023

gabalafou:
Looking at those screenshots I added, jeez we really need to fix the color contrast of our syntax highlighter 馃檲

@gabalafou This styling is from a third-party theme, here's point of import.

Code Hike theme docs.

Originally posted by @bskinn in #815 (comment)
@bskinn bskinn added area: design 馃帹 labs 馃敪 Items related to the Labs website area: react owner: Quansight For Quansight work, regardless of timing/priority type: design flaw 馃Н Similar to a "bug" but for a design miss labels Nov 30, 2023
@bskinn bskinn changed the title [DESIGN] Fix the color contrast of our syntax highlighter [DESIGN] Fix the color contrast of the syntax highlighter Nov 30, 2023
@bskinn bskinn mentioned this issue Nov 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: design 馃帹 area: react labs 馃敪 Items related to the Labs website owner: Quansight For Quansight work, regardless of timing/priority type: design flaw 馃Н Similar to a "bug" but for a design miss
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bskinn