Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Evaluate Labs vs Consulting blog machinery and resolve or document the differences #699

Open
bskinn opened this issue Mar 24, 2023 · 0 comments
Labels
area: react consulting 🤝 Items on the Quansight Consulting site labs 🔭 Items related to the Labs website needs: investigation 🔍 type: maintenance 🛠

Comments

@bskinn
Copy link
Contributor

bskinn commented Mar 24, 2023

Originally posted by @gabalafou in #577 (review)


I’ve given #577 a cursory review. Congratulations! This is a lot of work!

Most of it looks good to me. The only thing that really stands out to me is that there are some differences in how the code under consulting/services is organized compared to how it’s organized under labs/services, and I would like to have those differences eliminated.

The reason is that the differences lead to confusing inconsistencies. For example, both Labs and Consulting contain a key file named serializePost.ts. Under Labs the path to that file is:

labs/services/posts/serializePost.ts

In this PR currently, under Consulting, the path is:

consulting/services/posts/getLibraryPosts/serializePost.ts

Is there a good reason to keep these inconsistencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: react consulting 🤝 Items on the Quansight Consulting site labs 🔭 Items related to the Labs website needs: investigation 🔍 type: maintenance 🛠
Projects
None yet
Development

No branches or pull requests

1 participant