Added isindex function. #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing on master and are unrelated. |
asmeurer
reviewed
May 19, 2020
asmeurer
reviewed
May 19, 2020
|
It should also include the base index types. For integer indices the most correct thing is to check if |
|
By "base" I mean built-in, like tuple, slice, int, etc., as well as valid index numpy arrays (is it possible numpy already has such a function?). |
|
Sorry it took me so long, let me know if this is enough. |
|
This looks good to me. CC @asmeurer |
|
It looks like there are some conflicts here now |
scopatz
reviewed
Sep 9, 2020
ndindex/ndindex.py
Outdated
| if exclude and ((int in exclude) or (Integer in exclude)): | ||
| return False | ||
| else: | ||
| return True |
There was a problem hiding this comment.
It seems like this if-statement doesn't need to be in the try-block
|
Closing this as I assume it's not relevant anymore, cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if this is the right format for the "exclude" flag.
Closes #30