Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accessible dark theme #55

Open
tonyfast opened this issue Jun 27, 2023 · 1 comment
Open

accessible dark theme #55

tonyfast opened this issue Jun 27, 2023 · 1 comment

Comments

@tonyfast
Copy link
Contributor

this package is great. thanks for making it. it is cool to see more canonical systems joining the package.

there is an immediate need a recommended accessible dark theme for the syntax highlighting. this need is raised by a recent notebook v7 audit jupyter/notebook#6929

is there a dark theme on roadmap that might be more appropriate as base theme? could it provide some recommendations that might immediately improve the dark them in v7?

@steff456
Copy link
Contributor

Yes! Right now we have one PR for adding the Github dark theme, after this one is merged and other issues are fixed we will make another release.

I do also want to fix the issues that are present in the audit, for that we will need to work on creating a full themes for Jupyter light/dark. Right now we have around 6 accessible themes that we want to add before working on this, so we may take a while to make this happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog 🗃
Development

No branches or pull requests

3 participants