Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for language files #101

Open
dgillier opened this issue Jun 9, 2020 · 1 comment
Open

Add support for language files #101

dgillier opened this issue Jun 9, 2020 · 1 comment
Labels
Feature Feature request / feature being added via PR testing v5 version 5, supports both API and self hosted

Comments

@dgillier
Copy link

dgillier commented Jun 9, 2020

Hello,

I tried to add @lang params while editing a template but this is really making the preview unusable.

Screenshot 2020-06-09 at 16 03 50

not sure how to solve this, any idea ?
Thanks, Denis

@dgillier dgillier added the Feature Feature request / feature being added via PR label Jun 9, 2020
@ReeceM
Copy link
Collaborator

ReeceM commented Jun 24, 2020

Hi @dgillier, do they not render when you are previewing the mailable?

I was going to suggest using the {{ __("email.teacher_validation.learn_more") }} to also render language files, but it would still look the same in the template editor.

The language files should render though when you are looking at the mailable that the template has been attached to, I think the blade @lang aren't going to be rendered in the template editor as it's not passed through the View compiler of Laravel.

Could you confirm if the issues is that it isn't rendering or if it is in the template side of things you would like a better display of the language file?

@ReeceM ReeceM added this to To do in Hacktoberfest Sep 27, 2020
@ReeceM ReeceM added this to the New Features and updates milestone Mar 9, 2021
@Qoraiche Qoraiche added v5 version 5, supports both API and self hosted testing labels Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature request / feature being added via PR testing v5 version 5, supports both API and self hosted
Projects
No open projects
Hacktoberfest
  
To do
Development

No branches or pull requests

3 participants