Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal_cycle_basis #1029

Open
quantumjim opened this issue Nov 13, 2023 · 4 comments · May be fixed by #1170
Open

minimal_cycle_basis #1029

quantumjim opened this issue Nov 13, 2023 · 4 comments · May be fixed by #1170
Assignees
Labels
good first issue Good for newcomers

Comments

@quantumjim
Copy link
Member

What is the expected enhancement?

Add minimal_cycle_basis, with the same functionality as that of NetworkX.

Will be used in Qiskit QEC's ArcCircuit.

@mtreinish mtreinish added the good first issue Good for newcomers label Nov 13, 2023
@mtreinish
Copy link
Member

For reference to anyone interested in implementing this the algorithm networkx is implementing is published here:
https://link.springer.com/article/10.1007/s00453-007-9064-z

@gluonhiggs
Copy link

@quantumjim @mtreinish I want to try this, but I want to make it clear first.

  1. Do we need to add minimal_cycle_basis module written in Rust?
  2. Should I add this to rustworkx-core/src/connectivity/?

@mtreinish
Copy link
Member

  1. Yes we need to implement an equivalent function in rust.
  2. Yes, implementing the core algorithm in rustworkx-core/src/connectivity is ideal, that would mean we could expose the functionality to any rust user. We'll still need to add a pyfunction to src/connectivity/mod.rs but that will just call rustworkx_core::connectivity::minimal_cycle_basis. You can use the existing cycle_basis function as a model for how you can implement this.

@gluonhiggs would you like me to assign this issue to you?

@gluonhiggs
Copy link

@mtreinish yes, sure!

@IvanIsCoding IvanIsCoding linked a pull request Apr 24, 2024 that will close this issue
@1ucian0 1ucian0 linked a pull request May 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants