Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant classes and methods #314

Open
Jiaweihu08 opened this issue Apr 16, 2024 · 0 comments
Open

Remove redundant classes and methods #314

Jiaweihu08 opened this issue Apr 16, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Jiaweihu08
Copy link
Member

Classes and methods, and their corresponding tests, are rendered redundant by algorithm changes such as domain-driven double pass and the latest changes introduced by multi-block files.

For instance, NormalizedWeight should not and cannot be merged since their updates come from domain sizes.

BlockWriter is not used - we use IndexFileWriter to write different blocks into a single file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant