Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors noticed #11

Open
eyo11 opened this issue Feb 25, 2021 · 0 comments
Open

Errors noticed #11

eyo11 opened this issue Feb 25, 2021 · 0 comments

Comments

@eyo11
Copy link

eyo11 commented Feb 25, 2021

For the truncated Gaussians notebook, the line for target_expectations seems wrong. You are using:
target_expectations = [f0(mv).mean(), f1(mv).mean()]

when you only want the second constraint to be 1, not the mean. The next question is the one that asks for the second constraint to be the mean. So, this should be used for target_expectations.
target_expectations = [f0(mv).mean(),1]

In the Loaded die notebook, this is used:
model = maxentropy.Model(samplespace)

When Model requires more than 1 argument and therefore gives an error in the notebook. Should be:
model = maxentropy.Model(f,samplespace)

In the same notebook, this is used:
model.fit(f, K)
Which gives an error, and should be just:
model.fit(K)

Also, I don't understand why the Model class has "if self.priorlogprobs is not None" i.e it's checking for priorlogprobs, when it doesn't even accept priorlogprobs in its parameter list.
Do the Model and BigModel class have any use? It seems the MinDivergenceModel and MCMinDivergenceModel rely only on BaseModel. Can Model and BigModel be deleted, without affecting the code?

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant