New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config needs to not be required #58
Comments
hey @bradcypert this issue seems interesting, can you explain it a bit |
@deepraj02 Currently when you use the steward app (test example) it tries to load your config file into the container (code). This line here assumes that the config file exists (code that needs to be modified) when it may not exist. We should check that the config file exists before executing this code, otherwise, we can just return early without doing the remainder of the code in that method. |
Hey, I've started working on this projects, I'll be raising PR's and Issues as I find them.
It'd be great if you could help me on these points. |
For what I've discovered the bin/ dir is for the CLI right? can I get a bit more detailed docs on these? |
@deepraj02 The CLI is optional and not required to build or run a steward app. Its predominantly used to help scaffold out a project, but is not necessary for running the application. |
We should try to find a config and if it doesn't exist, the app should fail gracefully.
This would be in the app package, as this is where the config loading takes place. This is likely just checking to see if the file exists before executing the code that loads it and maps items to config key-value pairs.
The text was updated successfully, but these errors were encountered: