Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heads up: Internal changes to Waitress #157

Open
digitalresistor opened this issue Jun 25, 2016 · 4 comments
Open

Heads up: Internal changes to Waitress #157

digitalresistor opened this issue Jun 25, 2016 · 4 comments

Comments

@digitalresistor
Copy link
Member

Just wanted to give you a heads up, I just released an alpha version of waitress, and I know StopableWSGIServer uses internal waitress API's. I don't think there should be any breakage, but wanted to bring it to your attention anyway.

Cheers :-D

@gawel
Copy link
Member

gawel commented Jun 30, 2016

Just tried to run tox -r locally. Everything seems fine. Thanks.

@gawel gawel closed this as completed Jul 21, 2016
@gawel gawel reopened this Jul 21, 2016
@gawel
Copy link
Member

gawel commented Jul 21, 2016

Looks like my local environment use 0.9 while travis use the beta.

I got some issue with python2.6 https://travis-ci.org/Pylons/webtest/jobs/146316437#L809

Any idea why ?

Looks like the ImportError: cannot import name trigger is a real waitress bug.

The ValueError: zero length field name in format maybe related to StopableWSGIServer

@digitalresistor
Copy link
Member Author

Python 2.6 is no longer supported by waitress.

@digitalresistor
Copy link
Member Author

Also, pip on travis is version 6.0, it does not understand the pep 440 versioning.

I would recommend using tox within travis, because it will create a virtualenv and generally use a newer version of pip.

See https://github.com/Pylons/waitress/blob/master/.travis.yml for a travis file that uses this. Note that we use the matrix support because for the longest time Travis did not support Python 3.5 directly, and the matrix was the only way to force Python 3.5 (seems that is now fixed).

This will make sure that builds on travis install the latest released version of packages on PyPi.

Support for Python 2.6 will also be dropped from WebOb 1.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants