Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please extend the documentation wrt exceptions that can be raised #133

Open
radekholy24 opened this issue Feb 28, 2015 · 0 comments
Open

Comments

@radekholy24
Copy link

Hello, sometimes the documentation mentions that a method can raise an exception but it doesn't mention the type of the exception. Sometimes there is no mention of any exception at all while it is clear that an exception must be raised. This means that I often end up with except Exception which is not a very good practice.

Let me mention some examples:

  • webtest.app.TestApp must raise an exception if the app argument is an invalid string
  • webtest.app.TestApp.get and friends must raise an exception if expect_errors==False
  • webtest.response.TestResponse.click must raise an exception if the link points to a failing URL
  • form.submit should verify it's possible to submit the form #134
  • webtest.forms.Form.submit must raise an exception if the action attribute of the form points to a failing URL
  • webtest.forms.Form.__setitem__ must raise an exception if the field does not exist or if the name matches multiple fields

Can you please improve the documentation of the exceptions that may occur?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant