Provide an enhanced JSON renderer

[zupo]

I like the pyramid_swagger renderer from pyramid_swagger library.

With it, I can remove custom renderers from the realworld example app. And less code is always nice.

We can probably reuse the idea, or possibly even some code.

[Vardhan-Kaashikar]

Hey @zupo I am new open source contributing, can I give this one a try?

[zupo]

@Vk24-hash: sure thing! Let me know if you need help.

[Vardhan-Kaashikar]

Thanks, actually I was searching that where am I supposed to make changes in the code, because the issue is of pyramid_openapi3 repo and the custom renderer link provided by you is from real-world-example-app repository. But it shows that the code is integrated with pyramid_openapi3. Also if changes are to be made in the given link should I just completely replace the JSON renderer with pyramid_swagger renderer

…

On Wed, Feb 17, 2021 at 10:13 PM Nejc Zupan ***@***.***> wrote: @Vk24-hash <https://github.com/Vk24-hash>: sure thing! Let me know if you need help. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASKRO4MVPQMGB3PFNXTA5WLS7PW35ANCNFSM4HOXLW4A> .

[zupo]

The idea is to ship pyramid_openapi3 with a custom JSON renderer, so that applications using pyramid_openapi3 (for example, the real-world-example-app) do not need to come up with their own custom JSON renderer -- they just use what pyramid_openapi3 provides.

[Vardhan-Kaashikar]

okay and just completely replace the JSON renderer with pyramid_swagger renderer ?

…

On Thu, Feb 18, 2021 at 8:27 PM Nejc Zupan ***@***.***> wrote: The idea is to ship pyramid_openapi3 with a custom JSON renderer, so that applications using pyramid_openapi3 (for example, the real-world-example-app) do not need to come up with their own custom JSON renderer -- they just use what pyramid_openapi3 provides. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASKRO4I3OVZD6P42PDT7HDTS7UTEBANCNFSM4HOXLW4A> .

[zupo]

I suppose, yes. I cannot know until I see it in action.

[Vardhan-Kaashikar]

hey I tried doing some changes with the renderer don't know if it is right at all, please help me out.

…

On Fri, Feb 19, 2021 at 1:20 AM Nejc Zupan ***@***.***> wrote: I suppose, yes. I cannot know until I see it in action. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASKRO4O3TBSCS4NZBCOYLCTS7VVR7ANCNFSM4HOXLW4A> .

[zupo]

Where are the changes?

[Vardhan-Kaashikar]

I did some changes in the pyramid-real-world-example but it failed to pass the tests

…

On Mon, Feb 22, 2021 at 10:35 PM Nejc Zupan ***@***.***> wrote: Where are the changes? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASKRO4MQSVKXHG6DIC3YFI3TAKFEJANCNFSM4HOXLW4A> .

[zupo]

Ah yes, now I remember. The changes should be done here in this repo.

And yes, tests need to pass before the PR can be merged :)

[Vardhan-Kaashikar]

So where should I make the changes ?

…

On Tue, 23 Feb 2021, 00:52 Nejc Zupan, ***@***.***> wrote: Ah yes, now I remember. The changes should be done here in this repo. And yes, tests need to pass before the PR can be merged :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASKRO4O6WLKP5HPMXWQPF6TTAKVGFANCNFSM4HOXLW4A> .

[zupo]

I haven't thought this through so this is coming from the top of my head: it seems it makes sense to have a renderers.py file in https://github.com/Pylons/pyramid_openapi3/blob/master/pyramid_openapi3/.

[Vardhan-Kaashikar]

So am I supposed to make a file, because I have no idea where to start and what's the output of the project, if I am supposed to make one pls guide me, or should I just wait.

…

On Tue, 23 Feb 2021, 01:05 Nejc Zupan, ***@***.***> wrote: I haven't thought this through so this is coming from the top of my head: it seems it makes sense to have a renderers.py file in https://github.com/Pylons/pyramid_openapi3/blob/master/pyramid_openapi3/. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASKRO4N4BBMGKPXFJGRLE7LTAKWYHANCNFSM4HOXLW4A> .

[zupo]

Maybe a good approach is to familiarize yourself with Pyramid, this tutorial is good: https://docs.pylonsproject.org/projects/pyramid/en/latest/quick_tutorial/

[stevepiercy]

The Quick Tutorial is good for learning concepts in Pyramid. For a realistic application, I would point you to the wiki tutorial, which implements the concepts learned in the Quick Tutorial using best practices.

[Vardhan-Kaashikar]

Okay, I'll check it out.

…

On Fri, 26 Feb 2021, 05:27 Steve Piercy, ***@***.***> wrote: The Quick Tutorial is good for learning concepts in Pyramid. For a realistic application, I would point you to the wiki tutorial <https://docs.pylonsproject.org/projects/pyramid/en/latest/tutorials/wiki2/index.html>, which implements the concepts learned in the Quick Tutorial using best practices. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASKRO4K2HZ6DM66FXRDKKOTTA3PXFANCNFSM4HOXLW4A> .